This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
Allow universal access from file if flag is set and url is file scheme. #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BUG=449075 TEST=content_unittests --gtest_filter=NavigationControllerTest.IsInPageNavigation Review URL: https://codereview.chromium.org/855883002 Cr-Commit-Position: refs/heads/master@{#313051} (cherry picked from commit 3d42643)
|
To fix bug https://crosswalk-project.org/jira/browse/XWALK-3344. @rakuco , please take a look. Thanks! |
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
Jan 27, 2015
Cr-Commit-Position: refs/branch-heads/2214@{crosswalk-project#230}
Cr-Branched-From: 03655fd-refs/heads/master@{#303346}
rakuco
added a commit
that referenced
this pull request
Jan 27, 2015
Allow universal access from file if flag is set and url is file scheme.
rakuco
pushed a commit
that referenced
this pull request
Feb 27, 2015
…ium.org/899323002/ BUG=None TEST=None TBR=pkotwicz Review URL: https://codereview.chromium.org/904773002 Cr-Commit-Position: refs/branch-heads/2272@{#230} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
rakuco
pushed a commit
that referenced
this pull request
Apr 30, 2015
BUG=481210 [email protected] Review URL: https://codereview.chromium.org/1090863005 Cr-Commit-Position: refs/heads/master@{#326921} Review URL: https://codereview.chromium.org/1106893002 Cr-Commit-Position: refs/branch-heads/2357@{#230} Cr-Branched-From: 59d4494-refs/heads/master@{#323860}
rakuco
pushed a commit
that referenced
this pull request
Aug 13, 2015
In https://codereview.chromium.org/1239243002 a bug was introduced where media stream permission requests were not being persisted. This is because I believed that this code was never being reached but this was in error. This fixes that bug and adds a test. BUG=515041 Review URL: https://codereview.chromium.org/1255063004 Cr-Commit-Position: refs/heads/master@{#341481} (cherry picked from commit 8eadb2a) Review URL: https://codereview.chromium.org/1270243002 . Cr-Commit-Position: refs/branch-heads/2454@{#230} Cr-Branched-From: 12bfc33-refs/heads/master@{#338390}
mrunalk
pushed a commit
that referenced
this pull request
Sep 22, 2015
… field trials. The current heuristics for banner triggering are hard-coded. This CL allows the minimum time between visits that are counted for the purposes of banner triggering to be varied via field trials. The time will default to the current value, which is one visit per day (implemented by bucketing all visits to local midnight time). The new implementation will bucket to a given resolution in minutes, where the specified resolution is less than one day and evenly divisible into the number of minutes in a day. BUG=487519 Review URL: https://codereview.chromium.org/1306693005 Cr-Commit-Position: refs/heads/master@{#345228} (cherry picked from commit b6d06bf) Review URL: https://codereview.chromium.org/1336903002 . Cr-Commit-Position: refs/branch-heads/2490@{#230} Cr-Branched-From: 7790a35-refs/heads/master@{#344925}
mrunalk
pushed a commit
that referenced
this pull request
Dec 18, 2015
This patch makes spell checker not to crash with long text ends with uneditable element. When spell checker attempt check a text longer than |kChunkSize=16*1024| characters, |SpellChecker::chunkAndMarkAllMisspellingsAndBadGrammar()| breaks a text into chunks with sentence boundary by |expandRangeToSentenceBoundary()| using |startOfSentence()| and |endOfSentence()|. Before this patch, when |startOfSentence()| or |endOfSentence()| return null position, |expandRangeToSentenceBoundary()| returns empty range and subsequent spell checking code is crashed. This patch changes to check whether |expandRangeToSentenceBoundary()| returns empty range or not and to exclude empty range from spell checking. BUG=535223 TEST=LayoutTests/editing/spelling/spellcheck-mixed-editable-long-text-crash.html Review URL: https://codereview.chromium.org/1492663003 Cr-Commit-Position: refs/heads/master@{#362664} (cherry picked from commit 6e3e5ac) Review URL: https://codereview.chromium.org/1492243005 . Cr-Commit-Position: refs/branch-heads/2564@{#230} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
May 17, 2016
…It contains v8 cache options and the data saver pref value. Whether or not Data Saver is enabled is provided by the ChromeContentBrowserClient. This value is read by ServiceWorkerProcessManager::AllocateWorkerProcess and is propagated to WebEmbeddedWorkerImpl::prepareShadowPageForLoader(). This is a near term fix; changes to the data saver state do not update the embedded worker once created. BUG=587242 Review URL: https://codereview.chromium.org/1708583003 Cr-Commit-Position: refs/heads/master@{#380283} (cherry picked from commit e8a146f) Review URL: https://codereview.chromium.org/1800903002 . Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#230} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
Oct 9, 2016
Use context->Global() instead of CreationContext in MainThreadDebugger::memoryInfo. BUG=616225 [email protected],[email protected] Review-Url: https://codereview.chromium.org/2034203002 Cr-Commit-Position: refs/heads/master@{#397887} (cherry picked from commit 6c932f8) Review URL: https://codereview.chromium.org/2043543002 . Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#230} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
This reverts commit 049eaa1. Reason for revert: <INSERT REASONING HERE> Original change's description: > Download auto-open files to temp folder > > If a user has marked a file extension to auto-open on download, we > assume that the user only intends to use the file for one-time use. > Therefore, these files are now downloaded to the system temp directory > to prevent cluttering the user's download folder. > > Download the file again -- the first file will be in your downloads > folder, but the second one will be in the temp directory. > > Bug: 55567 > Test: Download a file and choose to Always Open Files of This Type. > Change-Id: If23db247f7ed03df7c4f2492c3fefe5e37c8f8ca > Reviewed-on: https://chromium-review.googlesource.com/602788 > Commit-Queue: David Trainor <[email protected]> > Reviewed-by: David Trainor <[email protected]> > Cr-Commit-Position: refs/heads/master@{#493787} [email protected],[email protected],[email protected] # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 55567 Change-Id: Ie1c3df69c1bf05d7291bc6373b3f9a4254a03d5f Reviewed-on: https://chromium-review.googlesource.com/655877 Reviewed-by: David Trainor <[email protected]> Commit-Queue: David Trainor <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#500693}(cherry picked from commit 2843aad) Reviewed-on: https://chromium-review.googlesource.com/667411 Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#230} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG=449075
TEST=content_unittests --gtest_filter=NavigationControllerTest.IsInPageNavigation
Review URL: https://codereview.chromium.org/855883002
Cr-Commit-Position: refs/heads/master@{#313051}
(cherry picked from commit 3d42643)