This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
Remove some resources in pak file under gyp flag #246
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 3, 2015 20:58
hrtf means "Head-related transfer function". It's to put the source in a 3-D related position to the listener. Without this feature, we can remove all the impluse wav resources. This patch is the backport from Crosswalk-lite
Remove following resources: 1. Resources for media player control bar, this part is not usually used, thus it could be overriden by web developers. 2. The ui resources are for aura/views, Android doesn't need it. This patch is the backport from Crosswalk-lite
|
Testing patch series with lincsoon/chromium-crosswalk@b831d109086d86f3ffca250923d9a3817a6cb3e8 as its head.
|
rakuco
pushed a commit
that referenced
this pull request
Apr 13, 2015
This CL: - Introduces the EF_BACK_MOUSE_BUTTON and EF_FORWARD_MOUSE_BUTTON event flags. - Removes X11 dependencies from BrowserCommandHandlerX11 and makes it used on Ozone and X11 - Removes the X11 specific handling from BrowserCommandHandlerX11 - Makes Ozone set the ui::EF_BACK_MOUSE_BUTTON flag for BTN_SIDE and BTN_BACK - Makes Ozone set the ui::EF_FORWARD_MOUSE_BUTTON flag for BTN_EXTRA and BTN_FORWARD BUG=462907 TEST=Manual, see bug TBR=pkotwicz Review URL: https://codereview.chromium.org/1017473002 Cr-Commit-Position: refs/branch-heads/2311@{#246} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
rakuco
pushed a commit
that referenced
this pull request
Apr 30, 2015
As discussed in https://codereview.chromium.org/1070433002/, this CL allows arbitrary scale factors, which works because chromium uses the resource most closely matching the scale factor (e.g. 1x for 1.25x, but 2x for 1.9x) and scales it. BUG=143619,477716 Review URL: https://codereview.chromium.org/1078423002 Cr-Commit-Position: refs/heads/master@{#326851} (cherry picked from commit b3ca230) device scale factor detection: use gtk-xft-dpi consistently Before this CL, we used either gtk-xft-dpi (UI fonts) or the physical DPI of a more or less random display. This CL consistently uses gtk-xft-dpi which is the better alternative: users can directly influence it (by changing the Xft.dpi X resource, or via their gtkrc). See also https://github.com/derat/font-config-info for displaying your current system settings. This is a re-do of https://codereview.chromium.org/1070433002/, but with https://codereview.chromium.org/1084453002/ applied (fixes content_shell). BUG=473089, 143619 Review URL: https://codereview.chromium.org/1085603002 Cr-Commit-Position: refs/heads/master@{#324928} (cherry picked from commit d459a5c) [email protected] TBR=erg, estade, oshima Review URL: https://codereview.chromium.org/1103383004 Cr-Commit-Position: refs/branch-heads/2357@{#246} Cr-Branched-From: 59d4494-refs/heads/master@{#323860}
rakuco
pushed a commit
that referenced
this pull request
Aug 13, 2015
UsbMidiDeviceFactoryAndroid.enumerateDevices should return false if there are connected USB devices, but they all are not MIDI. [email protected] BUG=513134 Review URL: https://codereview.chromium.org/1253183006 Cr-Commit-Position: refs/heads/master@{#340883} (cherry picked from commit 1ca345e) Review URL: https://codereview.chromium.org/1276503003 . Cr-Commit-Position: refs/branch-heads/2454@{#246} Cr-Branched-From: 12bfc33-refs/heads/master@{#338390}
mrunalk
pushed a commit
that referenced
this pull request
Sep 22, 2015
BUG=524291 Review URL: https://codereview.chromium.org/1315233006 Cr-Commit-Position: refs/heads/master@{#347873} (cherry picked from commit 582fd8f) Review URL: https://codereview.chromium.org/1339763004 . Cr-Commit-Position: refs/branch-heads/2490@{#246} Cr-Branched-From: 7790a35-refs/heads/master@{#344925}
rakuco
pushed a commit
that referenced
this pull request
Mar 3, 2016
This CL fixes a crash in NavigationHandleImpl when a Throttle tries to resume a navigation twice. A check was hit in NavigationHandleImpl::Resume, now the function will just be a no-op in that case. BUG=570200 Review URL: https://codereview.chromium.org/1610583002 Cr-Commit-Position: refs/heads/master@{#370371} (cherry picked from commit 21b595f) Review URL: https://codereview.chromium.org/1651413003 . Cr-Commit-Position: refs/branch-heads/2623@{#246} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
May 17, 2016
Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#246}
Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
Oct 9, 2016
Use the prediction type and max length attribute of the field to determine the number (if any) of character to truncate from the start of the expiration year when filling an input field. BUG=616174 TEST=AutofillFieldTest Review-Url: https://codereview.chromium.org/2025063002 Cr-Commit-Position: refs/heads/master@{#396956} (cherry picked from commit 103c242) NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2029403003 Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#246} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
This CL addresses a couple of bugs related to group id computations. First, the default output device isn't correctly identified as GetPrimaryActiveOutputNodeOnMainThread function doesn't actually set the output value. Second, default input device id was assumed to correspond to the built-in microphone in earlier versions of the code. This isn't true (and wasn't true before either). Now, we actually look up what device is the default input device. BUG=636300,764228 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ief22bfa5dffe29279dd906dd252c4d2489f30f1b Reviewed-on: https://chromium-review.googlesource.com/662761 Reviewed-by: Wu-Cheng Li <[email protected]> Commit-Queue: Max Morin <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#501240}(cherry picked from commit a00d6fa) Reviewed-on: https://chromium-review.googlesource.com/667149 Reviewed-by: Max Morin <[email protected]> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#246} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport following patches from Crosswalk-lite
Add gyp flag use_minimum_resources and exclude unnecessary resources.
Add flag to disable hrtf in webaudio
BUG=XWALK-3928