Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

Add flag to diable hrtf in webaudio #247

Merged
merged 1 commit into from
May 15, 2015
Merged

Add flag to diable hrtf in webaudio #247

merged 1 commit into from
May 15, 2015

Conversation

sunlin-link
Copy link
Contributor

The code in blink project will use the flag disable_webaudio_hrtf to reduce the binary size.

This patch is backported from the crosswalk-lite branch.

@crosswalk-trybot
Copy link

Testing patch series with lincsoon/chromium-crosswalk@2a943c4f56267e6f2ce06f816734804e9cac6cb9 as its head.

Bot Status
Content Shell Linux [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Linux/builds/176)
Content Shell Android-x86 [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Android-x86/builds/177)

@sunlin-link
Copy link
Contributor Author

@halton

@halton
Copy link

halton commented Apr 10, 2015

LGTM, ping @darktears

@darktears
Copy link
Contributor

Please inform the size benefit

@sunlin-link
Copy link
Contributor Author

This patch just adds the flag, doesn't really reduce the size. The size benefit is declared in the PR51 of blink which has already been merged

rakuco pushed a commit that referenced this pull request Apr 13, 2015
@reveman-chromium
cc: Release pixel refs after decoding images.
e45e873 
Not doing this causes images to be cached as long as the
layer they were found in exists and that results in
huge increase in memory usage as well as reduced
performance.

This is fixed by releasing the pixel ref as soon as
the image has been decoded.

BUG=429418,467017

Review URL: https://codereview.chromium.org/1008603004

Cr-Commit-Position: refs/heads/master@{#320522}
(cherry picked from commit 6821a17)

Review URL: https://codereview.chromium.org/1017513002

Cr-Commit-Position: refs/branch-heads/2311@{#247}
Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
@crosswalk-trybot
Copy link

Testing patch series with lincsoon/chromium-crosswalk@3f0691b0e0d2c692e7e02799146d817ce01abd95 as its head.

Bot Status
Content Shell Android-x86 [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Android-x86/builds/178)
Content Shell Linux [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Linux/builds/177)

@halton
Copy link

halton commented Apr 15, 2015

LGTM

@crosswalk-trybot
Copy link

Testing patch series with lincsoon/chromium-crosswalk@6fb7b773b41f83ef048bc0984e10b5b2c7a1f795 as its head.

Bot Status
Content Shell Android-x86 [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Android-x86/builds/179)
Content Shell Linux [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Linux/builds/178)

@sunlin-link
Copy link
Contributor Author

@darktears rebased

@crosswalk-trybot
Copy link

Testing patch series with lincsoon/chromium-crosswalk@11c6838bf023707b2036880f3f31847000749b7f as its head.

Bot Status
Content Shell Android-x86 [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Android-x86/builds/180)
Content Shell Linux [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Linux/builds/179)

@halton
Copy link

halton commented Apr 27, 2015

@darktears The reduced size is mentioned in Blink PR crosswalk-project/blink-crosswalk#51.

@halton
Copy link

halton commented Apr 29, 2015

@lincsoon please rebase code.

rakuco pushed a commit that referenced this pull request Apr 30, 2015
Merge M43: Fix crash on Enrollment screen.
58e5cab 
This is a sequel to crbug/470977, with a similar cause. This time, crash
is induced by WizardController re-creation, so the old NetworkErrorModel
pointers become invalid. Lesson learned: WizardController should NOT be
the owner of an ErrorScreen instance.

BUG=479666

Review URL: https://codereview.chromium.org/1098303002

Cr-Commit-Position: refs/heads/master@{#326317}
(cherry picked from commit 97422a9)

Review URL: https://codereview.chromium.org/1107363002

Cr-Commit-Position: refs/branch-heads/2357@{#247}
Cr-Branched-From: 59d4494-refs/heads/master@{#323860}
@crosswalk-trybot
Copy link

Testing patch series with lincsoon/chromium-crosswalk@b08a8611301aadd18ed679fe08bddcaf3489a2d9 as its head.

Bot Status
Content Shell Android-x86 [FAILED 💔](https://build.crosswalk-project.org/try/builders/Content Shell Android-x86/builds/184)
Content Shell Linux [FAILED 💔](https://build.crosswalk-project.org/try/builders/Content Shell Linux/builds/183)

Add flag to diable hrtf in webaudio
4c14a79 
The code in blink project will use this flag to reduce the binary size.

This patch is backported from the crosswalk-lite branch.
@crosswalk-trybot
Copy link

Testing patch series with lincsoon/chromium-crosswalk@4c14a792524757e304762479233db044a615433a as its head.

Bot Status
Content Shell Android-x86 [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Android-x86/builds/185)
Content Shell Linux [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Linux/builds/184)

@sunlin-link
Copy link
Contributor Author

@halton rebased

@halton
Copy link

halton commented May 15, 2015

@darktears , could you merge it?

darktears added a commit that referenced this pull request May 15, 2015
@darktears
Merge pull request #247 from lincsoon/backport1
87fbdb3 
Add flag to diable hrtf in webaudio
@darktears darktears merged commit 87fbdb3 into crosswalk-project:master May 15, 2015
@sunlin-link sunlin-link deleted the backport1 branch May 27, 2015 03:18
rakuco pushed a commit that referenced this pull request Aug 13, 2015
@tommynyquist
Add histogram for tracking the time for retrieving system accounts.
6e2542f 
On Android, it might be slow to retrieve the list of accounts, and
as such, we should track how long time it takes to query for them,
since this is done from the main thread.

BUG=509826

Review URL: https://codereview.chromium.org/1260663004

Cr-Commit-Position: refs/heads/master@{#341228}
(cherry picked from commit 96bb0fd)

Review URL: https://codereview.chromium.org/1277823002 .

Cr-Commit-Position: refs/branch-heads/2454@{#247}
Cr-Branched-From: 12bfc33-refs/heads/master@{#338390}
mrunalk pushed a commit that referenced this pull request Sep 22, 2015
Fix list of xtbs in policy_templates.grd and remoting_strings.grd.
1768226 
policy_templates.grd failed to list "fa", while remoting_strings.grd was
missing 11 xtbs. As a result, these strings were missing translations in
several languages.

BUG=518020

Review URL: https://codereview.chromium.org/1308743008

Cr-Commit-Position: refs/heads/master@{#348736}
(cherry picked from commit 9ccdaf6)

Review URL: https://codereview.chromium.org/1341953002 .

Cr-Commit-Position: refs/branch-heads/2490@{#247}
Cr-Branched-From: 7790a35-refs/heads/master@{#344925}
mrunalk pushed a commit that referenced this pull request Dec 18, 2015
@tkent-google
Close tooltip for |title| attribute on any keyboard event.
ae05498 
The new behavior is reasonable because tooltips can disturb text editing
with keyboards, and is compatible with Firefox.

BUG=557660
TEST=automated

Review URL: https://codereview.chromium.org/1454363002

Cr-Commit-Position: refs/heads/master@{#360555}
(cherry picked from commit ba5314a)

Review URL: https://codereview.chromium.org/1505673002 .

Cr-Commit-Position: refs/branch-heads/2564@{#247}
Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
rakuco pushed a commit that referenced this pull request Mar 3, 2016
@ccameron-chromium
cc: Fix bug where tabs have the wrong scale factor
d0fb775 
Device scale factor impacts the draw properties (in particular, the
transforms of the TransformNodes in the property tree). So, mark that
draw properties need to be updated when device scale factor changes.

BUG=567832
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1633043004

Cr-Commit-Position: refs/heads/master@{#371659}
(cherry picked from commit a65c79b)

Review URL: https://codereview.chromium.org/1656413002 .

Cr-Commit-Position: refs/branch-heads/2623@{#247}
Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin pushed a commit to huningxin/chromium-croswalk that referenced this pull request May 17, 2016
@efimki
[Cronet] CronetUploadDataStream now checks remaining read length.
d0808c6 
Throw exception in onReadSucceeded if bytesRead exceeds remaining read length.

BUG=589878

Review URL: https://codereview.chromium.org/1739303002

Cr-Commit-Position: refs/heads/master@{#380982}
(cherry picked from commit 7aefaa5)

[email protected]

Review URL: https://codereview.chromium.org/1801303002 .

Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#247}
Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin pushed a commit to huningxin/chromium-croswalk that referenced this pull request Oct 9, 2016
@sgraham
Fix scrollbar buttons on ChromeOS.
ee145b0 
Scrollbar buttons aren't supposed to draw on ChromeOS, so they need to
return a size of 0.

BUG=613668

Review-Url: https://codereview.chromium.org/2006643004
Cr-Commit-Position: refs/heads/master@{#396012}
(cherry picked from commit 57decb6)

Review URL: https://codereview.chromium.org/2042023002 .

Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#247}
Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto pushed a commit to tenta-browser/chromium-crosswalk that referenced this pull request Nov 2, 2017
Reland "[Merge M62] Chrome Cleaner UI: record prompt shown only if pr…
a2a8b44 
…ompt is shown"

This is a reland of 665eeaa
Original change's description:
> [Merge M62] Chrome Cleaner UI: record prompt shown only if prompt is shown
> 
> [email protected]
> 
> (cherry picked from commit aedad54)
> 
> Bug: 763943
> Change-Id: Ic16aa5ef180f8e8607e9f161f3f11a5e68ba0b63
> Reviewed-on: https://chromium-review.googlesource.com/660399
> Commit-Queue: Fabio Tirelo <[email protected]>
> Reviewed-by: Chris Sharp <[email protected]>
> Reviewed-by: Ali Tofigh <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#501024}
> Reviewed-on: https://chromium-review.googlesource.com/667797
> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#227}
> Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}

Bug: 763943
Change-Id: I2a4c1d5b9ba610a290f74b988476ab0b973b451c
Reviewed-on: https://chromium-review.googlesource.com/667498
Reviewed-by: Ali Tofigh <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#247}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
imreotto pushed a commit to tenta-browser/chromium-crosswalk that referenced this pull request Nov 2, 2017
Revert "Reland "[Merge M62] Chrome Cleaner UI: record prompt shown on…
f6a38b4 
…ly if prompt is shown""

This reverts commit a2a8b44.

Reason for revert: Unexpected merge conflict issue.

Original change's description:
> Reland "[Merge M62] Chrome Cleaner UI: record prompt shown only if prompt is shown"
> 
> This is a reland of 665eeaa
> Original change's description:
> > [Merge M62] Chrome Cleaner UI: record prompt shown only if prompt is shown
> > 
> > [email protected]
> > 
> > (cherry picked from commit aedad54)
> > 
> > Bug: 763943
> > Change-Id: Ic16aa5ef180f8e8607e9f161f3f11a5e68ba0b63
> > Reviewed-on: https://chromium-review.googlesource.com/660399
> > Commit-Queue: Fabio Tirelo <[email protected]>
> > Reviewed-by: Chris Sharp <[email protected]>
> > Reviewed-by: Ali Tofigh <[email protected]>
> > Cr-Original-Commit-Position: refs/heads/master@{#501024}
> > Reviewed-on: https://chromium-review.googlesource.com/667797
> > Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#227}
> > Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
> 
> Bug: 763943
> Change-Id: I2a4c1d5b9ba610a290f74b988476ab0b973b451c
> Reviewed-on: https://chromium-review.googlesource.com/667498
> Reviewed-by: Ali Tofigh <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#247}
> Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}

[email protected],[email protected],[email protected]

Change-Id: I29f52b9d0d496f9fe6f182210ea0214e421fe3b8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 763943
Reviewed-on: https://chromium-review.googlesource.com/668897
Reviewed-by: Ali Tofigh <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#253}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
imreotto pushed a commit to tenta-browser/chromium-crosswalk that referenced this pull request Nov 2, 2017
Reland "Reland "[Merge M62] Chrome Cleaner UI: record prompt shown on…
ce0c484 
…ly if prompt is shown""

This is a reland of a2a8b44
Original change's description:
> Reland "[Merge M62] Chrome Cleaner UI: record prompt shown only if prompt is shown"
> 
> This is a reland of 665eeaa
> Original change's description:
> > [Merge M62] Chrome Cleaner UI: record prompt shown only if prompt is shown
> > 
> > [email protected]
> > 
> > (cherry picked from commit aedad54)
> > 
> > Bug: 763943
> > Change-Id: Ic16aa5ef180f8e8607e9f161f3f11a5e68ba0b63
> > Reviewed-on: https://chromium-review.googlesource.com/660399
> > Commit-Queue: Fabio Tirelo <[email protected]>
> > Reviewed-by: Chris Sharp <[email protected]>
> > Reviewed-by: Ali Tofigh <[email protected]>
> > Cr-Original-Commit-Position: refs/heads/master@{#501024}
> > Reviewed-on: https://chromium-review.googlesource.com/667797
> > Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#227}
> > Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
> 
> Bug: 763943
> Change-Id: I2a4c1d5b9ba610a290f74b988476ab0b973b451c
> Reviewed-on: https://chromium-review.googlesource.com/667498
> Reviewed-by: Ali Tofigh <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#247}
> Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}

Bug: 763943
Change-Id: Id4d4c18d3bd86258e174854a24a9a6db8b049fc2
Reviewed-on: https://chromium-review.googlesource.com/668898
Reviewed-by: Ali Tofigh <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#266}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sunlin-link @crosswalk-trybot @halton @darktears