This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
[Temp] Declare v8_use_external_startup_data in build_overrides/v8.gni #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the Chromium side of crosswalk-project/v8-crosswalk#166. Kind of revert 0908bc7 ("[Backport] gn: Remove unnecessary v8 defaults") in the sense that `v8_use_external_startup_data` is being declared in build_overrides/v8.gni again, but it is now enclosed in a `declare_args` block. We cannot just get rid of it as intended in 0908bc7, as M52's V8 does not contain `gni/v8.gni` and a lot of declarations are done in V8's top-level `BUILD.gn` instead. Once we move to M53, V8 will work as intended and we will only need to properly backport https://codereview.chromium.org/2058033002 to chromium-crosswalk.
|
Testing patch series with rakuco/chromium-crosswalk@44aed2e as its head.
|
|
lgtm |
|
Thanks @rakuco. I have removed those 2 changes in next in latest update from master and backported the upstream commit you mentioned. |
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
When WebMediaPlayer is destroyed while remoting, the remoting UI should be hidden. Previous approach (https://chromium-review.googlesource.com/c/581950) added the notification in RendererController's destructor, which requires proper destruct order in WebMediaPlayerImpl, and potentially cause crash. This CL reverted previous change and instead hide the remoting UI directly in media element when media player is cleared. [email protected] (cherry picked from commit 8729914) Bug: 761699 Change-Id: I10452f93785a8e5814b4cffe466846d55962fa1e Reviewed-on: https://chromium-review.googlesource.com/600950 Commit-Queue: Yuri Wiitala <[email protected]> Reviewed-by: Mounir Lamouri <[email protected]> Reviewed-by: Yuri Wiitala <[email protected]> Reviewed-by: Chrome Cunningham <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#501741} Reviewed-on: https://chromium-review.googlesource.com/676756 Reviewed-by: Xiangjun Zhang <[email protected]> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#381} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the Chromium side of crosswalk-project/v8-crosswalk#166.
Kind of revert 0908bc7 ("[Backport] gn: Remove unnecessary v8 defaults")
in the sense that
v8_use_external_startup_datais being declared inbuild_overrides/v8.gni again, but it is now enclosed in a
declare_argsblock.
We cannot just get rid of it as intended in 0908bc7, as M52's V8 does
not contain
gni/v8.gniand a lot of declarations are done in V8'stop-level
BUILD.gninstead.Once we move to M53, V8 will work as intended and we will only need to
properly backport https://codereview.chromium.org/2058033002 to
chromium-crosswalk.