Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

Make all the readonly attributes in Device Capabilities valid. #2316

Conversation

scuxiayiqian
Copy link

Bug = XWALK-2162

@crosswalk-trybot
Copy link

Testing patch series with scuxiayiqian/crosswalk@009d1de as its head.

Bot Status
Crosswalk Tizen IVI [FAILED 💔](https://build.crosswalk-project.org/try/builders/Crosswalk Tizen IVI/builds/1697)
Crosswalk Tizen 3 Common [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Crosswalk Tizen 3 Common/builds/1292)
Crosswalk Android-X86 [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Crosswalk Android-X86/builds/1706)
Crosswalk Tizen 3 Mobile [FAILED 💔](https://build.crosswalk-project.org/try/builders/Crosswalk Tizen 3 Mobile/builds/1710)
Crosswalk Linux [FAILED 💔](https://build.crosswalk-project.org/try/builders/Crosswalk Linux/builds/1706)

@halton
Copy link

halton commented Aug 19, 2014

nice patch, could you force update and push again (without any change) to retrigger the trybot?

@halton
Copy link

halton commented Aug 19, 2014

And please do same thing for android part, src/runtime/android/core_internal/src/org/xwalk/core/internal/extension/api/device_capabilities/device_capabilities_api.js

@kygx-legend
Copy link
Contributor

@halton , I think in Android part it is already made read-only. In Tizen part, it is integrated at common.js and someone forgot to make them read-only.

@halton
Copy link

halton commented Aug 19, 2014

@legendlee1314 thanks for let me know.

@crosswalk-trybot
Copy link

Testing patch series with scuxiayiqian/crosswalk@c8a9a68 as its head.

Bot Status
Crosswalk Tizen IVI [FAILED 💔](https://build.crosswalk-project.org/try/builders/Crosswalk Tizen IVI/builds/1705)
Crosswalk Tizen 3 Common [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Crosswalk Tizen 3 Common/builds/1300)
Crosswalk Android-X86 [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Crosswalk Android-X86/builds/1714)
Crosswalk Tizen 3 Mobile [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Crosswalk Tizen 3 Mobile/builds/1718)
Crosswalk Linux [FAILED 💔](https://build.crosswalk-project.org/try/builders/Crosswalk Linux/builds/1714)

@halton
Copy link

halton commented Aug 20, 2014

hi @scuxiayiqian please squash your two commits.

@crosswalk-trybot
Copy link

Testing patch series with scuxiayiqian/crosswalk@2bbf490 as its head.

Bot Status
Crosswalk Tizen IVI [FAILED 💔](https://build.crosswalk-project.org/try/builders/Crosswalk Tizen IVI/builds/1706)
Crosswalk Linux [FAILED 💔](https://build.crosswalk-project.org/try/builders/Crosswalk Linux/builds/1715)
Crosswalk Android-X86 [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Crosswalk Android-X86/builds/1715)
Crosswalk Tizen 3 Mobile [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Crosswalk Tizen 3 Mobile/builds/1719)
Crosswalk Tizen 3 Common [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Crosswalk Tizen 3 Common/builds/1301)

@crosswalk-trybot
Copy link

Testing patch series with scuxiayiqian/crosswalk@63824f0 as its head.

Bot Status
Crosswalk Tizen IVI [FAILED 💔](https://build.crosswalk-project.org/try/builders/Crosswalk Tizen IVI/builds/1750)
Crosswalk Tizen 3 Common [FAILED 💔](https://build.crosswalk-project.org/try/builders/Crosswalk Tizen 3 Common/builds/1348)
Crosswalk Android-X86 [FAILED 💔](https://build.crosswalk-project.org/try/builders/Crosswalk Android-X86/builds/1759)
Crosswalk Tizen 3 Mobile [FAILED 💔](https://build.crosswalk-project.org/try/builders/Crosswalk Tizen 3 Mobile/builds/1764)
Crosswalk Linux [FAILED 💔](https://build.crosswalk-project.org/try/builders/Crosswalk Linux/builds/1759)

@halton
Copy link

halton commented Aug 25, 2014

lgtm, will merge when trybot get green.

@halton
Copy link

halton commented Aug 27, 2014

@legendlee1314 please retrigger the trybot.

@kygx-legend
Copy link
Contributor

This is not my PR. I don't know how to do that.

@halton
Copy link

halton commented Aug 27, 2014

oh do you know is @scuxiayiqian still available?

@kygx-legend
Copy link
Contributor

She is on leave for school courses now.

@halton
Copy link

halton commented Aug 27, 2014

Then could you fork this work and submit a new one?

@kygx-legend
Copy link
Contributor

Sure.

@halton
Copy link

halton commented Aug 27, 2014

Close since dup with #2355

@halton halton closed this Aug 27, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants