Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

Fix REGRESSION(9dcf2c8): "Support install application on Tizen". #588

Merged
merged 2 commits into from
Sep 9, 2013
Merged

Fix REGRESSION(9dcf2c8): "Support install application on Tizen". #588

merged 2 commits into from
Sep 9, 2013

Conversation

ds-hwang
Copy link
Contributor

@ds-hwang ds-hwang commented Sep 6, 2013

Fix REGRESSION(9dcf2c8): "Support install application on Tizen".

@Trybot
Copy link

Trybot commented Sep 6, 2013

Trybot Dashboard

The building Status of PATCH

Mon Sep 09 2013 21:35:12 GMT+0800 (CST) [xwalk_linux] Building...
Mon Sep 09 2013 22:32:16 GMT+0800 (CST) [xwalk_win] Failed LOGS: failed xwalk_browsertest
Tue Sep 10 2013 00:21:45 GMT+0800 (CST) [xwalk_aura] Failed LOGS: failed xwalk_browsertest
Mon Sep 09 2013 22:33:46 GMT+0800 (CST) [xwalk_android] Passed LOGS: build successful

@ds-hwang
Copy link
Contributor Author

ds-hwang commented Sep 6, 2013

@kenchris @takethathe @rakuco @darktears @shaochangbin
This patch makes web app use xwalk executable, not script as I discussed in http://linux.intel.com/pipermail/cameo-dev/2013-September/001090.html

@ds-hwang ds-hwang mentioned this pull request Sep 6, 2013
Merged
@ds-hwang
Copy link
Contributor Author

ds-hwang commented Sep 9, 2013

takethathe@9dcf2c8
was already landed that is almost same to this patch. So this patch only changed script file.

@ds-hwang ds-hwang mentioned this pull request Sep 9, 2013
Closed
@ds-hwang
[Tizen] xwalk script does not add command lines.
0bf39ab 
Xwalk script doesn't need to add additional command lines because since
9dcf2c8 "Support install application on Tizen", xwalk binary handles them
internally.

BUG=#609
@ds-hwang
[Tizen] Prevent fullscreen.
417aae0 
REGRESSION(9dcf2c8): "Support install application on Tizen".

We don't need to enforce fullscreen because xwalk makes the same size window to
the default screen.

BUG=#609
darktears added a commit that referenced this pull request Sep 9, 2013
@darktears
Merge pull request #588 from luxtella/xwalkscript
f1ad8e5 
Make Xwalk script do nothing.
@darktears darktears merged commit f1ad8e5 into crosswalk-project:master Sep 9, 2013
@ds-hwang ds-hwang deleted the xwalkscript branch September 9, 2013 17:37
@takethathe takethathe mentioned this pull request Sep 12, 2013
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ds-hwang @Trybot @darktears