IPv6: dhcp/provisioner: make ipv6 aware #1723

matthewoliver · 2018-12-05T05:00:21Z

If the admin network is IPv6 setup the ISC DHCPD server to configure
and use the IPv6 daemon. For this use a seperate set of ipv6 files
to list hosts and subnets as ipv6 hosts and subnets will fail if
v4 dhcp tries to load them.

Also make sure tftp is listening on both IPv4 and v6.

To make this all happen the Network class in the Barclamp::Inventory
library now tracks the ip_version of the network. Which is used to
make decisions through the DHCP and provisioner cookbooks.

To support backwards compatibilty with ipv4 config naming in the
DHCP barclamp a DhcpHelper was added to return config names in
an IPv4 or IPv6 way. The same pattern was used throughout the
barclamp in the early versions of this patch so it's been
refectered to the helper.

Finally, when dealing with some IPv6 addresses in URIs the address
needs to be wrapped. As such the network barclamp has grown a
NetworkHelper module to start gathering network related helper
method's, it's first is a wrap_ip function. Which will wrap an
address if it happens to an IPv6 address. This makes this available
to us anywhere in crowbar, so long as the network barclamp has been
applied, and as a core barclamp to crowbar, should be always.

hound · 2018-12-05T05:00:49Z

chef/cookbooks/dhcp/recipes/default.rb

+file "/etc/dhcp3/hosts.d/host6_list.conf" do
+  owner "root"
+  group "root"
+  mode 0644


Style/NumericLiteralPrefix: Use 0o for octal literals. (https://github.com/bbatsov/ruby-style-guide#numeric-literal-prefixes)

hound · 2018-12-05T05:00:49Z

chef/cookbooks/dhcp/recipes/default.rb

+file "/etc/dhcp3/subnets.d/subnet6_list.conf" do
+  owner "root"
+  group "root"
+  mode 0644


Style/NumericLiteralPrefix: Use 0o for octal literals. (https://github.com/bbatsov/ruby-style-guide#numeric-literal-prefixes)

hound · 2018-12-05T05:00:49Z

chef/cookbooks/dhcp/recipes/default.rb

+file "/etc/dhcp3/groups.d/group6_list.conf" do
+  owner "root"
+  group "root"
+  mode 0644


Style/NumericLiteralPrefix: Use 0o for octal literals. (https://github.com/bbatsov/ruby-style-guide#numeric-literal-prefixes)

hound · 2018-12-05T05:00:49Z

chef/cookbooks/provisioner/recipes/dhcp_update.rb

+    "option domain-name \"#{domain_name}\"",
+    "option domain-name-servers #{dns_servers.join(", ")}"
+  ]
+end


Lint/Syntax: unexpected token kEND

hound · 2018-12-05T05:00:49Z

chef/cookbooks/provisioner/recipes/dhcp_update.rb

+    "option domain-name \"#{domain_name}\"",
+    "option dhcp6.name-servers #{dns_servers.join(", ")}"
+  ]
+else


Lint/Syntax: unexpected token kELSE

Go home Hound, you're drunk.

hound · 2018-12-05T05:00:49Z

chef/cookbooks/provisioner/recipes/base.rb

 crowbar_node = node_search_with_cache("roles:crowbar").first
 address = crowbar_node["crowbar"]["network"]["admin"]["address"]
 protocol = crowbar_node["crowbar"]["apache"]["ssl"] ? "https" : "http"
-server = "#{protocol}://#{address}"
+if IPAddr.new(address).ipv6? rescue false


Lint/Syntax: unexpected token kRESCUE_MOD

hound · 2018-12-05T05:00:50Z

chef/cookbooks/dhcp/providers/subnet.rb

 action :add do
+  subnet_template = if IPAddr.new(new_resource.network["subnet"].ipv6? rescue false
+    "subnet6.conf.erb"
+  else


Lint/Syntax: unexpected token kELSE

hound · 2018-12-05T05:00:50Z

chef/cookbooks/dhcp/providers/subnet.rb

 action :add do
+  subnet_template = if IPAddr.new(new_resource.network["subnet"].ipv6? rescue false


Lint/Syntax: unexpected token kRESCUE_MOD

hound · 2018-12-05T05:00:50Z

chef/cookbooks/dhcp/providers/host.rb

-      options: new_resource.options
+      options: new_resource.options,
+      prefix: new_resource.prefix,
+      is_ipv6: IPAddr.new(new_resource.ipaddress).ipv6? rescue false


Lint/Syntax: unexpected token kRESCUE_MOD

hound · 2018-12-05T05:00:50Z

chef/cookbooks/dhcp/attributes/default.rb

@@ -10,4 +10,16 @@
    "option dhcp-client-debug code 226 = unsigned integer 16",
    "option dhcp-client-debug 0"
 ]
+default[:dhcp][:options][:v6] = [
+    "ddns-update-style none",


Layout/IndentArray: Use 2 spaces for indentation in an array, relative to the start of the line where the left square bracket is.

That's a sensible comment from hound 😉 It seems we are using 4 spaces everywhere else.

yeah, it's times like this I wonder should I just fix the hound "error" everywhere in the file to get it to pass or just ignore it. I mean we use 4 spaces everywhere here, so am keeping with the style.

You have two choices: Ignore Hound, or push a fix-up commit and then base your changes on top of that.

hound · 2018-12-05T06:18:35Z

chef/cookbooks/provisioner/recipes/dhcp_update.rb

+     } else if option dhcp6.client-arch-type = 00:09 {
+       option dhcp6.bootfile-url \"tftp://[#{admin_ip}]/discovery/x86_64/efi/default/boot/bootx64.efi\";
+     } else if option dhcp6.client-arch-type = 00:0b {
+       option dhcp6.bootfile-url \"tftp://[#{admin_ip}]/discovery/aarch64/efi/default/boot/bootaa64.efi\";


Metrics/LineLength: Line is too long. [106/100] (https://github.com/SUSE/style-guides/blob/master/Ruby.md#metricslinelength)

hound · 2018-12-05T06:18:35Z

chef/cookbooks/provisioner/recipes/dhcp_update.rb

+     } else if option dhcp6.client-arch-type = 00:07 {
+       option dhcp6.bootfile-url \"tftp://[#{admin_ip}]/discovery/x86_64/efi/default/boot/bootx64.efi\";
+     } else if option dhcp6.client-arch-type = 00:09 {
+       option dhcp6.bootfile-url \"tftp://[#{admin_ip}]/discovery/x86_64/efi/default/boot/bootx64.efi\";


Metrics/LineLength: Line is too long. [104/100] (https://github.com/SUSE/style-guides/blob/master/Ruby.md#metricslinelength)

hound · 2018-12-05T06:18:35Z

chef/cookbooks/provisioner/recipes/dhcp_update.rb

+             "if option dhcp6.client-arch-type = 00:06 {
+       option dhcp6.bootfile-url \"tftp://[#{admin_ip}]/discovery/ia32/efi/bootia32.efi\";
+     } else if option dhcp6.client-arch-type = 00:07 {
+       option dhcp6.bootfile-url \"tftp://[#{admin_ip}]/discovery/x86_64/efi/default/boot/bootx64.efi\";


Metrics/LineLength: Line is too long. [104/100] (https://github.com/SUSE/style-guides/blob/master/Ruby.md#metricslinelength)

hound · 2018-12-05T06:18:35Z

chef/cookbooks/provisioner/recipes/dhcp_update.rb

+       # Always send the PXELINUX options (specified in hexadecimal)
+       option dhcp-parameter-request-list = concat(option dhcp-parameter-request-list,d0,d1,d2,d3);
+     }',
+             "if option dhcp6.client-arch-type = 00:06 {


Layout/AlignArray: Align the elements of an array literal if they span more than one line. (https://github.com/bbatsov/ruby-style-guide#align-multiline-arrays)

hound · 2018-12-05T06:18:35Z

chef/cookbooks/provisioner/recipes/dhcp_update.rb

+ipv6_dhcp_opts = ["allow unknown-clients",
+             "default-lease-time #{lease_time}",
+             "max-lease-time #{lease_time}",
+             'if exists dhcp-parameter-request-list {


Layout/AlignArray: Align the elements of an array literal if they span more than one line. (https://github.com/bbatsov/ruby-style-guide#align-multiline-arrays)

hound · 2018-12-05T06:18:35Z

chef/cookbooks/provisioner/recipes/dhcp_update.rb

+
+ipv6_dhcp_opts = ["allow unknown-clients",
+             "default-lease-time #{lease_time}",
+             "max-lease-time #{lease_time}",


Layout/AlignArray: Align the elements of an array literal if they span more than one line. (https://github.com/bbatsov/ruby-style-guide#align-multiline-arrays)

hound · 2018-12-05T06:18:35Z

chef/cookbooks/provisioner/recipes/dhcp_update.rb

+             "next-server #{admin_ip}"]
+
+ipv6_dhcp_opts = ["allow unknown-clients",
+             "default-lease-time #{lease_time}",


Layout/AlignArray: Align the elements of an array literal if they span more than one line. (https://github.com/bbatsov/ruby-style-guide#align-multiline-arrays)

hound · 2018-12-05T06:18:35Z

chef/cookbooks/provisioner/recipes/dhcp_update.rb

@@ -31,18 +30,53 @@
     } else {
       filename = "discovery/x86_64/bios/pxelinux.0";
     }',
-             "next-server #{admin_ip}"],
+             "next-server #{admin_ip}"]


Layout/AlignArray: Align the elements of an array literal if they span more than one line. (https://github.com/bbatsov/ruby-style-guide#align-multiline-arrays)

hound · 2018-12-05T06:18:36Z

chef/cookbooks/provisioner/recipes/base.rb

 crowbar_node = node_search_with_cache("roles:crowbar").first
 address = crowbar_node["crowbar"]["network"]["admin"]["address"]
 protocol = crowbar_node["crowbar"]["apache"]["ssl"] ? "https" : "http"
-server = "#{protocol}://#{address}"
+if IPAddr.new(address).ipv6?


Style/ConditionalAssignment: Use the return of the conditional for variable assignment and comparison.

hound · 2018-12-05T23:24:02Z

chef/cookbooks/dhcp/providers/subnet.rb

-    file "/etc/dhcp3/subnets.d/subnet_list.conf"
-    if node[:provisioner][:enable_pxe]
-      notifies :restart, resources(service: "dhcp3-server"), :delayed
+  for subnet_list in ["subnet_list.conf", "subnet6_list.conf"] do


Style/For: Prefer each over for. (https://github.com/bbatsov/ruby-style-guide#no-for-loops)

hound · 2018-12-05T23:24:02Z

chef/cookbooks/dhcp/providers/host.rb

-    file "/etc/dhcp3/hosts.d/host_list.conf"
-    if node[:provisioner][:enable_pxe]
-      notifies :restart, resources(service: "dhcp3-server"), :delayed
+  for host_list in ["host_list.conf", "host6_list.conf"] do


Style/For: Prefer each over for. (https://github.com/bbatsov/ruby-style-guide#no-for-loops)

hound · 2018-12-05T23:24:02Z

chef/cookbooks/dhcp/providers/host.rb

-    file "/etc/dhcp3/hosts.d/host_list.conf"
-    if node[:provisioner][:enable_pxe]
-      notifies :restart, resources(service: "dhcp3-server"), :delayed
+  for host_list in ["host_list.conf", "host6_list.conf"] do


Style/For: Prefer each over for. (https://github.com/bbatsov/ruby-style-guide#no-for-loops)

hound · 2018-12-05T23:24:02Z

chef/cookbooks/dhcp/providers/subnet.rb

-    file "/etc/dhcp3/subnets.d/subnet_list.conf"
-    if node[:provisioner][:enable_pxe]
-      notifies :restart, resources(service: "dhcp3-server"), :delayed
+  for subnet_list in ["subnet_list.conf", "subnet6_list.conf"] do


Style/For: Prefer each over for. (https://github.com/bbatsov/ruby-style-guide#no-for-loops)

hound · 2018-12-06T05:44:19Z

chef/cookbooks/provisioner/recipes/setup_base_images.rb

@@ -298,12 +301,13 @@
      notifies :reload, resources(service: "xinetd")
    end
  else
+    ip_addr = admin_ip.ipv6? ? "[#{admin_ip.to_s}]" : admin_ip.to_s


Lint/StringConversionInInterpolation: Redundant use of Object#to_s in interpolation. (https://github.com/bbatsov/ruby-style-guide#no-to-s)

hound · 2018-12-06T05:44:19Z

chef/cookbooks/provisioner/recipes/setup_base_images.rb

 domain_name = node[:dns].nil? ? node[:domain] : (node[:dns][:domain] || node[:domain])
 web_port = node[:provisioner][:web_port]
-provisioner_web="http://#{admin_ip}:#{web_port}"
+provisioner_web="http://#{admin_ip.to_s}:#{web_port}" if admin_ip.ipv4?
+provisioner_web="http://[#{admin_ip.to_s}]:#{web_port}" if admin_ip.ipv6?


Layout/SpaceAroundOperators: Surrounding space missing for operator =. (https://github.com/bbatsov/ruby-style-guide#spaces-operators)
Lint/StringConversionInInterpolation: Redundant use of Object#to_s in interpolation. (https://github.com/bbatsov/ruby-style-guide#no-to-s)

hound · 2018-12-06T05:44:19Z

chef/cookbooks/provisioner/recipes/setup_base_images.rb

 domain_name = node[:dns].nil? ? node[:domain] : (node[:dns][:domain] || node[:domain])
 web_port = node[:provisioner][:web_port]
-provisioner_web="http://#{admin_ip}:#{web_port}"
+provisioner_web="http://#{admin_ip.to_s}:#{web_port}" if admin_ip.ipv4?


Layout/SpaceAroundOperators: Surrounding space missing for operator =. (https://github.com/bbatsov/ruby-style-guide#spaces-operators)
Lint/StringConversionInInterpolation: Redundant use of Object#to_s in interpolation. (https://github.com/bbatsov/ruby-style-guide#no-to-s)

hound · 2018-12-06T05:44:20Z

chef/cookbooks/provisioner/recipes/setup_base_images.rb

@@ -298,12 +301,13 @@
      notifies :reload, resources(service: "xinetd")
    end
  else
+    ip_addr = admin_ip.ipv6? ? "[#{admin_ip.to_s}]" : admin_ip.to_s


Lint/StringConversionInInterpolation: Redundant use of Object#to_s in interpolation. (https://github.com/bbatsov/ruby-style-guide#no-to-s)

hound · 2018-12-06T05:44:20Z

chef/cookbooks/provisioner/recipes/setup_base_images.rb

 domain_name = node[:dns].nil? ? node[:domain] : (node[:dns][:domain] || node[:domain])
 web_port = node[:provisioner][:web_port]
-provisioner_web="http://#{admin_ip}:#{web_port}"
+provisioner_web="http://#{admin_ip.to_s}:#{web_port}" if admin_ip.ipv4?
+provisioner_web="http://[#{admin_ip.to_s}]:#{web_port}" if admin_ip.ipv6?


Layout/SpaceAroundOperators: Surrounding space missing for operator =. (https://github.com/bbatsov/ruby-style-guide#spaces-operators)
Lint/StringConversionInInterpolation: Redundant use of Object#to_s in interpolation. (https://github.com/bbatsov/ruby-style-guide#no-to-s)

hound · 2018-12-06T05:44:20Z

chef/cookbooks/provisioner/recipes/setup_base_images.rb

 domain_name = node[:dns].nil? ? node[:domain] : (node[:dns][:domain] || node[:domain])
 web_port = node[:provisioner][:web_port]
-provisioner_web="http://#{admin_ip}:#{web_port}"
+provisioner_web="http://#{admin_ip.to_s}:#{web_port}" if admin_ip.ipv4?


Layout/SpaceAroundOperators: Surrounding space missing for operator =. (https://github.com/bbatsov/ruby-style-guide#spaces-operators)
Lint/StringConversionInInterpolation: Redundant use of Object#to_s in interpolation. (https://github.com/bbatsov/ruby-style-guide#no-to-s)

hound · 2018-12-10T03:29:37Z

chef/cookbooks/provisioner/recipes/dhcp_update.rb

+       option dhcp6.bootfile-url \"#{admin6_uri}/discovery/ppc64le/bios/\";
+     } else {
+       option dhcp6.bootfile-url \"#{admin6_uri}/x86_64/bios/pxelinux.0\";
+     }"]


Layout/MultilineArrayBraceLayout: Closing array brace must be on the line after the last array element when opening brace is on a separate line from the first array element.

hound · 2018-12-10T03:29:37Z

chef/cookbooks/provisioner/recipes/dhcp_update.rb

+             "next-server #{admin_ip}"]
+
+ipv6_dhcp_opts = [
+             "allow unknown-clients",


Layout/IndentArray: Use 2 spaces for indentation in an array, relative to the start of the line where the left square bracket is.

hound · 2018-12-10T03:29:37Z

chef/cookbooks/provisioner/recipes/dhcp_update.rb

@@ -31,18 +32,54 @@
     } else {
       filename = "discovery/x86_64/bios/pxelinux.0";
     }',
-             "next-server #{admin_ip}"],
+             "next-server #{admin_ip}"]


Layout/MultilineArrayBraceLayout: Closing array brace must be on the line after the last array element when opening brace is on a separate line from the first array element.

hound · 2018-12-10T03:29:37Z

chef/cookbooks/provisioner/recipes/dhcp_update.rb

-pool_opts = {
-  "dhcp" => ["allow unknown-clients",
+ipv4_dhcp_opts = [
+             "allow unknown-clients",


Layout/IndentArray: Use 2 spaces for indentation in an array, relative to the start of the line where the left square bracket is.

hound · 2018-12-10T03:29:38Z

chef/cookbooks/provisioner/recipes/dhcp_update.rb

+       option dhcp6.bootfile-url \"#{admin6_uri}/discovery/ppc64le/bios/\";
+     } else {
+       option dhcp6.bootfile-url \"#{admin6_uri}/x86_64/bios/pxelinux.0\";
+     }"]


Layout/MultilineArrayBraceLayout: Closing array brace must be on the line after the last array element when opening brace is on a separate line from the first array element.

hound · 2018-12-10T03:29:38Z

chef/cookbooks/provisioner/recipes/dhcp_update.rb

+             "next-server #{admin_ip}"]
+
+ipv6_dhcp_opts = [
+             "allow unknown-clients",


Layout/IndentArray: Use 2 spaces for indentation in an array, relative to the start of the line where the left square bracket is.

hound · 2018-12-10T03:29:38Z

chef/cookbooks/provisioner/recipes/dhcp_update.rb

@@ -31,18 +32,54 @@
     } else {
       filename = "discovery/x86_64/bios/pxelinux.0";
     }',
-             "next-server #{admin_ip}"],
+             "next-server #{admin_ip}"]


Layout/MultilineArrayBraceLayout: Closing array brace must be on the line after the last array element when opening brace is on a separate line from the first array element.

hound · 2018-12-10T03:29:38Z

chef/cookbooks/provisioner/recipes/dhcp_update.rb

-pool_opts = {
-  "dhcp" => ["allow unknown-clients",
+ipv4_dhcp_opts = [
+             "allow unknown-clients",


Layout/IndentArray: Use 2 spaces for indentation in an array, relative to the start of the line where the left square bracket is.

hound · 2018-12-10T03:37:08Z

chef/cookbooks/provisioner/recipes/dhcp_update.rb

@@ -31,18 +32,56 @@
     } else {
       filename = "discovery/x86_64/bios/pxelinux.0";
     }',
-             "next-server #{admin_ip}"],
+             "next-server #{admin_ip}"


Layout/AlignArray: Align the elements of an array literal if they span more than one line. (https://github.com/bbatsov/ruby-style-guide#align-multiline-arrays)

hound · 2018-12-10T03:37:09Z

chef/cookbooks/provisioner/recipes/dhcp_update.rb

@@ -31,18 +32,56 @@
     } else {
       filename = "discovery/x86_64/bios/pxelinux.0";
     }',
-             "next-server #{admin_ip}"],
+             "next-server #{admin_ip}"


Layout/AlignArray: Align the elements of an array literal if they span more than one line. (https://github.com/bbatsov/ruby-style-guide#align-multiline-arrays)

nicolasbock

This looks good to me.

nicolasbock · 2018-12-18T19:22:28Z

chef/cookbooks/dhcp/attributes/default.rb

@@ -10,4 +10,16 @@
    "option dhcp-client-debug code 226 = unsigned integer 16",
    "option dhcp-client-debug 0"
 ]
+default[:dhcp][:options][:v6] = [
+    "ddns-update-style none",


That's a sensible comment from hound 😉 It seems we are using 4 spaces everywhere else.

rktidwell · 2018-12-20T16:26:09Z

chef/cookbooks/dhcp/providers/subnet.rb

 action :add do
+  if IPAddr.new(new_resource.network["subnet"]).ipv6?


I've seen this sort of thing in a number of places. I wonder if it might be cleaner to use an ip_version variable to store 4 vs. 6, and then you can simply use ip_version as a suffix and do away with some if/else blocks and make any file names explicit (ie subnet4.conf.erb vs. subnet.conf.erb)

The way that crowbar updates and removes subnets from the list does make we worry about it from an upgrade perspective. I.e an existing env with subnet_list.conf with a bunch of subnets and we suddently change it. Will only "new" subnet source config lines be added.

I'll re-roll 1/2 way between. Leave ipv4 and subnet_list.conf and use subnet6_list.conf. But change to just adding a 6 or not. It does look much cleaner. Though ip_version = '' on ipv4 but. still cleaner then it was.

rktidwell · 2018-12-20T16:31:23Z

chef/cookbooks/dhcp/recipes/default.rb

+require "ipaddr"
+admin_addr = IPAddr.new(address)
+
+if admin_addr.ipv4?


See my previous comment about maybe referencing an ip_version variable. I also wonder if this precludes us from doing dual-stack, meaning we would have to come back to this and refactor it again.

Yeah, I have a feeling there might be a bunch or refactoring required for true dual stack. Currently crowbar only expects 1 network of each type. So I think a bunch of changes maybe be required for it to have more then 1 network for each type. I think once we're gone through single stack, we'll have a very good idea of how much of crowbar we need to touch.

Unfortunately if I was more experienced with Crowbar, maybe I'd be able to tell you outright. But this is a new journey into the crux of crowbar for me too ;)

nicolasbock · 2018-12-21T21:15:26Z

Rebased

rktidwell · 2019-01-04T18:28:02Z

chef/cookbooks/provisioner/recipes/setup_base_images.rb

@@ -525,7 +530,7 @@
        owner "root"
        group "root"
        source "crowbar_register.erb"
-        variables(admin_ip: admin_ip,
+        variables(admin_ip: admin_ip.to_s,
                  admin_broadcast: admin_net.broadcast,


What meaning does admin_net.broadcast have when dealing with IPv6? Is this something that should be set conditionally?

it'll be an empty string in IPv6 I believe.. which might make the crowbar_register script fail to find the correct interface (from a very quick look at the script) when attempting to register a new node with crowbar.

So I have a feeling we'll need to modify the register script some more. But that comes into play when were creating and registering nodes. So in the next few mkcloud steps after this one. But a good candidate for a new card in our backlog:

Test and modify crowbar_register to work with IPv6 addresses, as this script has comes reliance on broadcast addresses to find interfaces.

hound · 2019-01-07T01:12:58Z

crowbar_framework/app/models/api/upgrade.rb

@@ -1373,7 +1408,7 @@ def upgrade_all_compute_nodes
        upgrade_compute_nodes type
      end

-      def parallel_upgrade_compute_nodes(compute_nodes)
+      def parallel_upgrade_compute_nodes(compute_nodes, controller = nil)


Metrics/AbcSize: Assignment Branch Condition size for parallel_upgrade_compute_nodes is too high. [58.29/30] (https://github.com/SUSE/style-guides/blob/master/Ruby.md#metricsabcsize, http://c2.com/cgi/wiki?AbcMetric)
Metrics/CyclomaticComplexity: Cyclomatic complexity for parallel_upgrade_compute_nodes is too high. [11/6]
Metrics/MethodLength: Method has too many lines. [62/50] (https://github.com/bbatsov/ruby-style-guide#short-methods)
Metrics/PerceivedComplexity: Perceived complexity for parallel_upgrade_compute_nodes is too high. [11/7]

hound · 2019-01-07T01:12:58Z

crowbar_framework/app/models/api/upgrade.rb

        upgrade_nodes.each do |node|
          node.set_pre_upgrade_attribute
+          if node.roles.include?("cinder-controller") &&


Style/Next: Use next to skip iteration. (https://github.com/bbatsov/ruby-style-guide#no-nested-conditionals)

hound · 2019-01-07T01:12:59Z

chef/cookbooks/dhcp/providers/subnet.rb

+  ip_version = if IPAddr.new(new_resource.network["subnet"]).ipv6?
+    '6'
+  else
+    ''


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. (https://github.com/SUSE/style-guides/blob/master/Ruby.md#stylestringliterals)

hound · 2019-01-07T01:12:59Z

chef/cookbooks/dhcp/providers/subnet.rb

 action :add do
+  ip_version = if IPAddr.new(new_resource.network["subnet"]).ipv6?
+    '6'


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. (https://github.com/SUSE/style-guides/blob/master/Ruby.md#stylestringliterals)

hound · 2019-01-31T09:30:14Z

chef/cookbooks/provisioner/recipes/setup_base_images.rb

@@ -22,7 +22,8 @@
 admin_ip = admin_net.address
 domain_name = node[:dns].nil? ? node[:domain] : (node[:dns][:domain] || node[:domain])
 web_port = node[:provisioner][:web_port]
-provisioner_web="http://#{admin_ip}:#{web_port}"
+provisioner_web="http://#{admin_ip}:#{web_port}" unless admin_net.ip_version == "6"
+provisioner_web="http://[#{admin_ip}]:#{web_port}" if admin_net.ip_version == "6"


Layout/SpaceAroundOperators: Surrounding space missing for operator =. (https://github.com/bbatsov/ruby-style-guide#spaces-operators)

hound · 2019-01-31T09:30:14Z

chef/cookbooks/provisioner/recipes/setup_base_images.rb

@@ -22,7 +22,8 @@
 admin_ip = admin_net.address
 domain_name = node[:dns].nil? ? node[:domain] : (node[:dns][:domain] || node[:domain])
 web_port = node[:provisioner][:web_port]
-provisioner_web="http://#{admin_ip}:#{web_port}"
+provisioner_web="http://#{admin_ip}:#{web_port}" unless admin_net.ip_version == "6"


Layout/SpaceAroundOperators: Surrounding space missing for operator =. (https://github.com/bbatsov/ruby-style-guide#spaces-operators)

hound · 2019-01-31T09:30:14Z

chef/cookbooks/dhcp/recipes/default.rb

-address = Chef::Recipe::Barclamp::Inventory.get_network_by_type(node, "admin").address
+admin_network = Chef::Recipe::Barclamp::Inventory.get_network_by_type(node, "admin") 
+intfs = [admin_network.interface]
+address = admin_network.address


Lint/UselessAssignment: Useless assignment to variable - address. (https://github.com/bbatsov/ruby-style-guide#underscore-unused-vars)

hound · 2019-01-31T09:30:14Z

chef/cookbooks/dhcp/recipes/default.rb

@@ -60,21 +75,24 @@
 end

 # This needs to be evaled.
-intfs = [Chef::Recipe::Barclamp::Inventory.get_network_by_type(node, "admin").interface]
-address = Chef::Recipe::Barclamp::Inventory.get_network_by_type(node, "admin").address
+admin_network = Chef::Recipe::Barclamp::Inventory.get_network_by_type(node, "admin") 


Layout/TrailingWhitespace: Trailing whitespace detected. (https://github.com/bbatsov/ruby-style-guide#no-trailing-whitespace)

hound · 2019-01-31T09:30:14Z

chef/cookbooks/dhcp/providers/subnet.rb

@@ -14,10 +14,14 @@
 #

 action :add do
+  ip_version = new_resource.ip_version
+  if ip_version == "4"


Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||. (https://github.com/bbatsov/ruby-style-guide#if-as-a-modifier)

s-t-e-v-e-n-k

I love the direction this is going, with some cleanup, this should be awesome.

s-t-e-v-e-n-k · 2019-02-01T04:07:46Z

chef/cookbooks/dhcp/recipes/default.rb

+file "/etc/dhcp3/hosts.d/host6_list.conf" do
+  owner "root"
+  group "root"
+  mode 0644


Do we want to only write these out if ip_version is 6?

True, when originally writing this I was thinking about an environment that was dual stack. But your right, I'm already making assumptions based on the admin network and what version it is in order to create the correct dhcpd[6] config. I'll make the change to only write out for the ip_version of the admin net.

s-t-e-v-e-n-k · 2019-02-01T04:09:49Z

chef/cookbooks/dhcp/recipes/default.rb

-intfs = [Chef::Recipe::Barclamp::Inventory.get_network_by_type(node, "admin").interface]
-address = Chef::Recipe::Barclamp::Inventory.get_network_by_type(node, "admin").address
+admin_network = Chef::Recipe::Barclamp::Inventory.get_network_by_type(node, "admin")
+intfs = [admin_network.interface]


I'm concerned you've dropped address, is that really unused below?

it is unused.. but the comment above say. "# this needs to be evaled." so maybe it's where to make sure an address exists? All I know if hound complained because it was an unused variable. Will add it back as it was there before.

s-t-e-v-e-n-k · 2019-02-01T04:14:42Z

chef/cookbooks/dhcp/providers/subnet.rb

@@ -14,10 +14,13 @@
 #

 action :add do
+  ip_version = new_resource.ip_version
+  ip_version = "" if ip_version == "4"
+  end


This pattern keeps getting repeated. Perhaps a filename helper function in the barclamp library:

get_network_service_filename("subnet", new_resource) -> returns subnet.conf.erb or subnet6.conf.erb

s-t-e-v-e-n-k · 2019-02-01T04:16:20Z

chef/cookbooks/dhcp/templates/default/dhcpd.conf.erb

+include "/etc/dhcp3/groups.d/group6_list.conf";
+include "/etc/dhcp3/subnets.d/subnet6_list.conf";
+include "/etc/dhcp3/hosts.d/host6_list.conf";
+<% else -%>


Why are most of the included options commented out?

They are the default values from the "sample" config, there commented out there too. Really there there because maybe there something we may or may not what to tweak and left them here seeing as I haven't really testing the actual running dhcpd6 yet.. other then it starts.

Also it was WIP so figured doesn't hurt. I'll remove them for now.

s-t-e-v-e-n-k · 2019-02-01T04:18:38Z

chef/cookbooks/provisioner/recipes/base.rb

-server = "#{protocol}://#{address}"
+server = if IPAddr.new(address).ipv6?
+  "#{protocol}://[#{address}]"
+else


I sort of agree with the terrible dog here, surely there's something better here. Didn't we already add a function that will wrap only IPv6 addresses, meaning this logic can live in that function and we only call it here?

did we? I don't remember it. But doesn't mean there isn't... I do have young girls who don't sleep.. which means I don't :P

If we don't I'll add an address_wrapped to the network class.

We did -- as a shell function for mkcloud. However, I think it's a nice idea, and it will certainly be needed for future barclamps (think bind addresses), so we may as well add it now.

I added it to the barclamp Network class. We seem to use those, at least where I've seen em.
I could've added a NetworkHelper in the network barclamp which "would" be more obvious maybe.. but seeing as we already encapsulate the networks in the Barclamp network class I put it there.

s-t-e-v-e-n-k · 2019-02-01T04:19:31Z

chef/cookbooks/provisioner/recipes/dhcp_update.rb

+    "option domain-name \"#{domain_name}\"",
+    "option dhcp6.name-servers #{dns_servers.join(", ")}"
+  ]
+else


Go home Hound, you're drunk.

hound · 2019-02-04T03:27:02Z

chef/cookbooks/dhcp/recipes/default.rb

@@ -168,7 +174,7 @@

 service "dhcp3-server" do
  if %w(suse rhel).include?(node[:platform_family])
-    service_name "dhcpd"
+    service_name "#{DhcpHelper.config_filename("dhcpd", admin_network.ip_version, "")}"


Style/UnneededInterpolation: Prefer to_s over string interpolation.

oh yeah, I guess that makes more sense, thanks hound :)

hound · 2019-02-04T03:27:02Z

chef/cookbooks/dhcp/recipes/default.rb

-file "/etc/dhcp3/groups.d/group_list.conf" do
+# This needs to be evaled.
+admin_network = Chef::Recipe::Barclamp::Inventory.get_network_by_type(node, "admin")
+address = admin_network.address


Lint/UselessAssignment: Useless assignment to variable - address. (https://github.com/bbatsov/ruby-style-guide#underscore-unused-vars)

hound · 2019-02-04T03:27:03Z

chef/cookbooks/dhcp/providers/subnet.rb

@@ -33,7 +34,7 @@
  end
  utils_line "include \"#{filename}\";" do
    action :add
-    file "/etc/dhcp3/subnets.d/subnet_list.conf"
+    file "/etc/dhcp3/subnets.d/#{DhcpHelper.config_filename("subnet_list", new_resource.ip_version)}"


Metrics/LineLength: Line is too long. [101/100] (https://github.com/SUSE/style-guides/blob/master/Ruby.md#metricslinelength)

hound · 2019-02-04T03:27:03Z

chef/cookbooks/dhcp/providers/subnet.rb

  filename = "/etc/dhcp3/subnets.d/#{new_resource.subnet}.conf"
  template filename do
    cookbook "dhcp"
-    source "subnet.conf.erb"
+    source "#{subnet_template}"


Style/UnneededInterpolation: Prefer to_s over string interpolation.

lol, yeah, it's already a variable.

hound · 2019-02-04T03:27:03Z

chef/cookbooks/dhcp/libraries/helpers.rb

@@ -0,0 +1,9 @@
+module DhcpHelper
+  def self.config_filename(base, ip_version, extension=".conf")


Layout/SpaceAroundEqualsInParameterDefault: Surrounding space missing in default value assignment. (https://github.com/bbatsov/ruby-style-guide#spaces-around-equals)

Made changes, please re-review

hound · 2019-02-05T00:13:57Z

chef/cookbooks/network/libraries/helpers.rb

+      address.to_s
+    end
+  end
+end


Lint/Syntax: unexpected token kEND

hound · 2019-02-05T00:13:57Z

chef/cookbooks/network/libraries/helpers.rb

+    require "ipaddr"
+    if IPAddr.new(address).ipv6? rescue false
+      "[#{address}]"
+    else


Lint/Syntax: else without rescue is useless

hound · 2019-02-05T00:13:57Z

chef/cookbooks/network/libraries/helpers.rb

+module NetworkHelper
+  def self.wrap_ip(address)
+    require "ipaddr"
+    if IPAddr.new(address).ipv6? rescue false


Lint/Syntax: unexpected token kRESCUE_MOD

matthewoliver · 2019-02-05T06:01:00Z

This time forgot to remove the address_wrapped from the network class, which isn't required now that we have the NetworkHelper.

s-t-e-v-e-n-k

This is preceding in a fantastic direction, I have some concerns about the crowbar_join templates, but this is looking like amazing work.

s-t-e-v-e-n-k · 2019-02-07T04:50:10Z

chef/cookbooks/provisioner/templates/default/crowbar_join.suse.sh.erb

@@ -114,7 +114,11 @@ wait_for_hostname() {
 wait_for_admin_server() {
    # wait for admin server to become pingable
    tries_left=120
-    while ! ping -q -c1 $IP > /dev/null; do
+    local ping="ping"
+    if (( $IPV6 > 0 )); then


Where is that defined?

s-t-e-v-e-n-k · 2019-02-07T04:50:55Z

chef/cookbooks/provisioner/templates/default/crowbar_join.suse.sh.erb

+<% if @ip_version == "6" -%>
+IPV6=1
+<% else  -%>
+IPV6=0


Below where it is first used? I'm so confused.

yeah it is confusing, but really the code here is run first because it's outside of functions. Then it's used in functions. So was just following the pattern that was previously used for the $IP. As I figured once this is templated out into a bash script I wanted it to look like the old version as how knows in anyone ever goes in an hacks it. I guess they shouldn't.

I was lazy, so figured following an existing pattern and minimalise the change to the crowbar_join rather then refactor and probably cause or introduce bugs.

s-t-e-v-e-n-k · 2019-02-07T04:51:47Z

chef/cookbooks/provisioner/templates/suse/crowbar_register.erb

+  ADMIN_IP_WRAPPED="[ADMIN_IP]"
+else
+  ADMIN_IP_WRAPPED="ADMIN_IP"
+fi


Could we collapse these into one if block? They will effectively do the same thing anyway

yup, good point. I guess I shouldn't try and write back code that allows someone to easy hack on a machine (turn IPV6 to 0 or 1) cause it's not really making it any better.
DONE

s-t-e-v-e-n-k · 2019-02-07T04:53:15Z

chef/cookbooks/dhcp/libraries/helpers.rb

+      "#{base}#{extension}"
+    else
+      "#{base}#{ip_version}#{extension}"
+    end


To be fair I had envisioned this as always returning "#{base}#{extra}#{extension}" where extra gets set to 6 if ip_version is 6, but this is very much a nit.

s-t-e-v-e-n-k · 2019-02-07T04:54:40Z

chef/cookbooks/dhcp/attributes/default.rb

@@ -10,4 +10,16 @@
    "option dhcp-client-debug code 226 = unsigned integer 16",
    "option dhcp-client-debug 0"
 ]
+default[:dhcp][:options][:v6] = [
+    "ddns-update-style none",


You have two choices: Ignore Hound, or push a fix-up commit and then base your changes on top of that.

s-t-e-v-e-n-k · 2019-02-07T04:56:02Z

chef/cookbooks/provisioner/templates/default/crowbar_join.suse.sh.erb

@@ -163,9 +167,9 @@ do_setup() {
    # Make sure that the client knows how to talk to the server.
    local cfg=/etc/chef/client.rb
    if ! [ -f $cfg ] || \
-       ! grep -q "^\s*chef_server_url\s*[\"\']http://$IP:4000[\"\']" $cfg; then
+       ! grep -q "^\s*chef_server_url\s*[\"\']http://$IP_WRAPPED:4000[\"\']" $cfg; then


And this? Because below is ADMIN_IP_WRAPPED, not IP_WRAPPED ...

huh, it's all IP_WRAPPED in this script. Unless I'm missing something.. which might be possible :P

hound · 2019-02-11T04:13:37Z

chef/cookbooks/dhcp/libraries/helpers.rb

@@ -0,0 +1,10 @@
+module DhcpHelper
+  def self.config_filename(base, ip_version, extension = ".conf")
+    if ip_version == "4"


Style/ConditionalAssignment: Use the return of the conditional for variable assignment and comparison.

hound · 2019-02-11T04:13:37Z

chef/cookbooks/dhcp/libraries/helpers.rb

@@ -0,0 +1,10 @@
+module DhcpHelper
+  def self.config_filename(base, ip_version, extension = ".conf")
+    if ip_version == "4"


Style/ConditionalAssignment: Use the return of the conditional for variable assignment and comparison.

hound · 2019-02-11T04:13:37Z

chef/cookbooks/dhcp/libraries/helpers.rb

@@ -0,0 +1,10 @@
+module DhcpHelper
+  def self.config_filename(base, ip_version, extension = ".conf")
+    if ip_version == "4"


Style/ConditionalAssignment: Use the return of the conditional for variable assignment and comparison.

hound · 2019-03-28T04:29:48Z

chef/cookbooks/provisioner/recipes/update_nodes.rb

+     } else {
+       option dhcp6.bootfile-url \"#{admin6_uri}/x86_64/efi/#{boot_ip_hex}/boot/bootx64.efi\";
+     }"
+      ]


Layout/IndentArray: Indent the right bracket the same as the start of the line where the left bracket is.

hound · 2019-03-28T04:29:48Z

chef/cookbooks/provisioner/recipes/update_nodes.rb

-        ipaddress admin_ip_address
-        options [
-          "if exists dhcp-parameter-request-list {
+  if admin_data_net.ip_version == '6'


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. (https://github.com/SUSE/style-guides/blob/master/Ruby.md#stylestringliterals)

chef/cookbooks/provisioner/recipes/base.rb

s-t-e-v-e-n-k

With CI passing, we can think about landing this. I have only comment remaining, I think.

s-t-e-v-e-n-k · 2019-05-27T06:16:59Z

chef/cookbooks/provisioner/recipes/update_nodes.rb

-        ipaddress admin_ip_address
-        options [
-          "if exists dhcp-parameter-request-list {
+  if admin_data_net.ip_version == "6"


This looks to be very much duplicating the next block. I'm not going to block on it, but can comment that it could be refactored to be IP version agnostic.

hound · 2019-05-27T06:52:06Z

chef/cookbooks/barclamp/libraries/barclamp_library.rb

+            if @ip_version == "6"
+              IPAddr.new('ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff').mask(cidr).to_s
+            else
+              IPAddr.new('255.255.255.255').mask(cidr).to_s


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. (https://github.com/SUSE/style-guides/blob/master/Ruby.md#stylestringliterals)

hound · 2019-05-27T06:52:07Z

chef/cookbooks/barclamp/libraries/barclamp_library.rb

+
+          if cidr
+            if @ip_version == "6"
+              IPAddr.new('ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff').mask(cidr).to_s


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. (https://github.com/SUSE/style-guides/blob/master/Ruby.md#stylestringliterals)

hound · 2019-05-27T06:52:07Z

chef/cookbooks/barclamp/libraries/barclamp_library.rb

+            range = 32
+          end
+
+          cidr = Integer(@netmask) rescue nil


Style/RescueModifier: Avoid using rescue in its modifier form. (https://github.com/bbatsov/ruby-style-guide#no-rescue-modifiers)

hound · 2019-05-27T06:52:07Z

chef/cookbooks/barclamp/libraries/barclamp_library.rb

@@ -124,6 +132,30 @@ def interface_list
          @interface_list
        end

+        def cidr_to_netmask
+          if @ip_version == "6"


Style/ConditionalAssignment: Use the return of the conditional for variable assignment and comparison.

hound · 2019-05-27T06:52:07Z

chef/cookbooks/barclamp/libraries/barclamp_library.rb

@@ -124,6 +132,30 @@ def interface_list
          @interface_list
        end

+        def cidr_to_netmask


Metrics/CyclomaticComplexity: Cyclomatic complexity for cidr_to_netmask is too high. [7/6]
Metrics/PerceivedComplexity: Perceived complexity for cidr_to_netmask is too high. [10/7]

hound · 2019-05-27T06:52:11Z

chef/cookbooks/ntp/recipes/default.rb

@@ -79,7 +79,7 @@
    variables(ntp_servers: ntp_servers,
              admin_interface: local_admin_address,
              admin_subnet: admin_net.subnet,
-              admin_netmask: admin_net.netmask,
+              admin_netmask: admin_net.cidr_to_netmask(),


Style/MethodCallWithoutArgsParentheses: Do not use parentheses for method calls with no arguments. (https://github.com/bbatsov/ruby-style-guide#method-invocation-parens)

matthewoliver · 2019-05-27T06:55:37Z

Added to more commits to this PR. First adds the adminip to the kernel commandline so the new version of the sleshammer script can pick it up. And the second fixes the ntp configuration.
I've only roughly tested on my laptop. Tomorrow I'll work through hounds grips and clean up a little :)

nicolasbock · 2019-07-02T19:13:44Z

Rebased

If the admin network is IPv6 setup the ISC DHCPD server to configure and use the IPv6 daemon. For this use a seperate set of ipv6 files to list hosts and subnets as ipv6 hosts and subnets will fail if v4 dhcp tries to load them. Also make sure tftp is listening on both IPv4 and v6. To make this all happen the Network class in the Barclamp::Inventory library now tracks the ip_version of the network. Which is used to make decisions through the DHCP and provisioner cookbooks. To support backwards compatibilty with ipv4 config naming in the DHCP barclamp a DhcpHelper was added to return config names in an IPv4 or IPv6 way. The same pattern was used throughout the barclamp in the early versions of this patch so it's been refectered to the helper. Finally, when dealing with some IPv6 addresses in URIs the address needs to be wrapped. As such the network barclamp has grown a NetworkHelper module to start gathering network related helper method's, it's first is a wrap_ip function. Which will wrap an address if it happens to an IPv6 address. This makes this available to us anywhere in crowbar, so long as the network barclamp has been applied, and as a core barclamp to crowbar, should be always.

When the sleshammer discovery image boots on nodes in an IPv6 environment there is no sane way of determining the admin ip. In IPv4 we can grab it from the SERVERID produced by wicked's dhcpd4 binary. Except in IPv6 the serverid seems to the be DHCP DUID. This patch adds an 'adminip=..' option to the commandline for the discovery image. The start-up.sh script and sleshammer image has been modified seperately.

The ntp.conf used in crowbar wont work with IPv6 as the netmask in the ntp conf file need to be in the full form not CIDR. This patch adds a new method, cidr_to_subnet to the Barclamp library's Network class. Which is then used to send the correct string to the ntp.conf.erb template. Allowing the crowbar nodes being booted via the sleshammer discovery image to sync with the admin node.

hound · 2019-07-04T06:46:11Z

chef/cookbooks/bind9/recipes/default.rb

@@ -152,6 +152,10 @@ def make_zone(zone)

  zonefile_entries
 end
+def address_version(address)
+  'ip6addr' if IPAddr.new(address).ipv6?
+  'ip4addr' if IPAddr.new(address).ipv4?


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. (https://github.com/SUSE/style-guides/blob/master/Ruby.md#stylestringliterals)

hound · 2019-07-04T06:46:11Z

chef/cookbooks/bind9/recipes/default.rb

@@ -152,6 +152,10 @@ def make_zone(zone)

  zonefile_entries
 end
+def address_version(address)
+  'ip6addr' if IPAddr.new(address).ipv6?


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. (https://github.com/SUSE/style-guides/blob/master/Ruby.md#stylestringliterals)

hound · 2019-07-04T06:46:11Z

chef/cookbooks/bind9/recipes/default.rb

@@ -152,6 +152,10 @@ def make_zone(zone)

  zonefile_entries
 end
+def address_version(address)


Layout/EmptyLineBetweenDefs: Use empty lines between method definitions. (https://github.com/bbatsov/ruby-style-guide#empty-lines-between-methods)

matthewoliver added wip IPv6-CP labels Dec 5, 2018

hound bot reviewed Dec 5, 2018

View reviewed changes

hound bot reviewed Dec 6, 2018

View reviewed changes

hound bot reviewed Dec 10, 2018

View reviewed changes

matthewoliver force-pushed the ipv6-dhcpd branch from 56985b9 to add2a61 Compare December 10, 2018 03:36

hound bot reviewed Dec 10, 2018

View reviewed changes

matthewoliver force-pushed the ipv6-dhcpd branch from add2a61 to aeb5de9 Compare December 10, 2018 03:42

matthewoliver removed the wip label Dec 10, 2018

nicolasbock previously approved these changes Dec 18, 2018

View reviewed changes

matthewoliver dismissed nicolasbock’s stale review via 1dcdbb3 December 19, 2018 05:33

matthewoliver force-pushed the ipv6-dhcpd branch from aeb5de9 to 1dcdbb3 Compare December 19, 2018 05:33

rktidwell previously requested changes Dec 20, 2018

View reviewed changes

nicolasbock force-pushed the ipv6-dhcpd branch from 1dcdbb3 to 69e12d7 Compare December 21, 2018 21:15

rktidwell reviewed Jan 4, 2019

View reviewed changes

hound bot reviewed Jan 7, 2019

View reviewed changes

matthewoliver force-pushed the ipv6-dhcpd branch from a705dfa to 5bbc8be Compare January 7, 2019 02:35

hound bot reviewed Jan 31, 2019

View reviewed changes

s-t-e-v-e-n-k suggested changes Feb 1, 2019

View reviewed changes

hound bot reviewed Feb 4, 2019

View reviewed changes

matthewoliver force-pushed the ipv6-dhcpd branch from 3ffcf4c to ff932a1 Compare February 5, 2019 00:13

hound bot reviewed Feb 5, 2019

View reviewed changes

matthewoliver force-pushed the ipv6-dhcpd branch 2 times, most recently from 7a59c21 to df9ea11 Compare February 5, 2019 06:00

s-t-e-v-e-n-k suggested changes Feb 7, 2019

View reviewed changes

matthewoliver force-pushed the ipv6-dhcpd branch from df9ea11 to 08c544a Compare February 11, 2019 04:13

hound bot reviewed Feb 11, 2019

View reviewed changes

matthewoliver force-pushed the ipv6-dhcpd branch from 08c544a to c4645af Compare March 28, 2019 04:29

hound bot reviewed Mar 28, 2019

View reviewed changes

matthewoliver force-pushed the ipv6-dhcpd branch from c4645af to 9d58954 Compare March 28, 2019 04:46

matthewoliver force-pushed the ipv6-dhcpd branch from 9d58954 to 80e7244 Compare April 24, 2019 07:10

s-t-e-v-e-n-k reviewed May 23, 2019

View reviewed changes

chef/cookbooks/provisioner/recipes/base.rb Outdated Show resolved Hide resolved

matthewoliver force-pushed the ipv6-dhcpd branch from 80e7244 to 2b0ac08 Compare May 24, 2019 04:55

s-t-e-v-e-n-k self-requested a review May 24, 2019 05:28

s-t-e-v-e-n-k previously approved these changes May 27, 2019

View reviewed changes

matthewoliver dismissed s-t-e-v-e-n-k’s stale review via f087627 May 27, 2019 06:51

hound bot reviewed May 27, 2019

View reviewed changes

nicolasbock force-pushed the ipv6-dhcpd branch from f087627 to a8e9b8e Compare July 2, 2019 19:13

matthewoliver added 5 commits July 4, 2019 16:43

ipv6: add ipv6 support to control scripts, bind9 and more dhcp6 fixes

4e70134

IPv6: Make sure the address written to crowbarrc is wrapped

ee488f9

matthewoliver force-pushed the ipv6-dhcpd branch from a8e9b8e to ee488f9 Compare July 4, 2019 06:46

hound bot reviewed Jul 4, 2019

View reviewed changes

JanZerebecki added the wip label Jan 13, 2021

		action :add do
		subnet_template = if IPAddr.new(new_resource.network["subnet"].ipv6? rescue false

		action :add do
		if IPAddr.new(new_resource.network["subnet"]).ipv6?

		@@ -0,0 +1,9 @@
		module DhcpHelper
		def self.config_filename(base, ip_version, extension=".conf")

IPv6: dhcp/provisioner: make ipv6 aware #1723

Are you sure you want to change the base?

IPv6: dhcp/provisioner: make ipv6 aware #1723

Conversation

matthewoliver commented Dec 5, 2018 • edited Loading

hound bot Dec 5, 2018

Choose a reason for hiding this comment

hound bot Dec 5, 2018

Choose a reason for hiding this comment

hound bot Dec 5, 2018

Choose a reason for hiding this comment

hound bot Dec 5, 2018

Choose a reason for hiding this comment

hound bot Dec 5, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hound bot Dec 5, 2018

Choose a reason for hiding this comment

hound bot Dec 5, 2018

Choose a reason for hiding this comment

hound bot Dec 5, 2018

Choose a reason for hiding this comment

hound bot Dec 5, 2018

Choose a reason for hiding this comment

hound bot Dec 5, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hound bot Dec 5, 2018

Choose a reason for hiding this comment

hound bot Dec 5, 2018

Choose a reason for hiding this comment

hound bot Dec 5, 2018

Choose a reason for hiding this comment

hound bot Dec 5, 2018

Choose a reason for hiding this comment

hound bot Dec 5, 2018

Choose a reason for hiding this comment

hound bot Dec 5, 2018

Choose a reason for hiding this comment

hound bot Dec 5, 2018

Choose a reason for hiding this comment

hound bot Dec 5, 2018

Choose a reason for hiding this comment

hound bot Dec 5, 2018

Choose a reason for hiding this comment

hound bot Dec 5, 2018

Choose a reason for hiding this comment

hound bot Dec 5, 2018

Choose a reason for hiding this comment

hound bot Dec 5, 2018

Choose a reason for hiding this comment

hound bot Dec 5, 2018

Choose a reason for hiding this comment

hound bot Dec 6, 2018

Choose a reason for hiding this comment

hound bot Dec 6, 2018

Choose a reason for hiding this comment

hound bot Dec 6, 2018

Choose a reason for hiding this comment

hound bot Dec 6, 2018

Choose a reason for hiding this comment

hound bot Dec 6, 2018

Choose a reason for hiding this comment

hound bot Dec 6, 2018

Choose a reason for hiding this comment

hound bot Dec 10, 2018

Choose a reason for hiding this comment

hound bot Dec 10, 2018

Choose a reason for hiding this comment

hound bot Dec 10, 2018

Choose a reason for hiding this comment

hound bot Dec 10, 2018

Choose a reason for hiding this comment

hound bot Dec 10, 2018

Choose a reason for hiding this comment

hound bot Dec 10, 2018

Choose a reason for hiding this comment

hound bot Dec 10, 2018

matthewoliver commented Dec 5, 2018 •

edited

Loading