Support installation of Neutron ZVM Driver #27

dirkmueller · 2015-09-14T20:22:43Z

Allow deploying with the ZVM L2 driver.

houndci-bot · 2015-09-14T20:22:49Z

chef/data_bags/crowbar/migrate/neutron/043_add_zvm_attributes.rb

+end
+
+def downgrade ta, td, a, d
+  a.delete('zvm')


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

tboerger · 2015-09-16T07:01:35Z

Beside the style offenses LGTM

MaximilianMeister · 2015-09-16T07:13:14Z

chef/data_bags/crowbar/bc-template-neutron.schema

+                      "zvm_xcat_server": { "type": "str", "required": true },
+                      "zvm_xcat_username": { "type": "str", "required": true },
+                      "zvm_xcat_password": { "type": "str", "required": true }
+                    }},


will these 3 parameters then be taken out of nova? you have mentioned some day IIRC that nova could use these attributes from neutron, as neutron is required by nova anyway.

houndci-bot · 2015-12-08T10:27:28Z

chef/data_bags/crowbar/migrate/neutron/043_add_zvm_attributes.rb

+end
+
+def downgrade ta, td, a, d
+  a.delete('zvm')


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. (https://github.com/bbatsov/ruby-style-guide#consistent-string-literals)

houndci-bot · 2015-12-09T21:58:35Z

chef/cookbooks/neutron/recipes/common_agent.rb

+      mode "0640"
+      variables(
+        zvm: neutron[:neutron][:zvm]
+       )


Style/ClosingParenthesisIndentation: Indent ) the same as the start of the line where ( is.

bmwiedemann · 2016-01-12T16:56:48Z

chef/cookbooks/neutron/recipes/server.rb

+
+  # XXX define the xcat management network when needed
+  if true
+    external_networks += ["xcatvsw1"]


test failed with
undefined method `to_hash' for nil:NilClass
in cookbooks/neutron/libraries/helpers.rb
13: external_networks.each do |net|
14>> networks[net] = node["network"]["networks"][net].to_hash

not that it fixes the above error, but stylewise maybe use external_networks.push("xcatvsw1")

houndci-bot · 2016-01-27T13:03:12Z

chef/cookbooks/neutron/recipes/server.rb

@@ -13,8 +13,14 @@
 # limitations under the License.
 #

+zvm_compute_node = search(:node, "roles:nova-compute-zvm") || []
+use_zvm = not zvm_compute_node.empty?


unexpected token tIDENTIFIER
(Using Ruby 2.3 parser; configure using TargetRubyVersion parameter, under AllCops)

toabctl · 2016-01-27T14:33:58Z

chef/cookbooks/neutron/recipes/server.rb

@@ -169,6 +179,9 @@
  #TODO(vuntz): temporarily disable the hyperv mechanism since we're lacking networking-hyperv from stackforge
  #ml2_mechanism_drivers = node[:neutron][:ml2_mechanism_drivers].dup.push("hyperv")
  ml2_mechanism_drivers = node[:neutron][:ml2_mechanism_drivers].dup
+  if zvm_compute_node.first


if use_zvm ...

toabctl · 2016-01-27T16:19:31Z

+1 (assuming you tested it and it works)

vuntz · 2016-01-27T16:36:39Z

chef/cookbooks/neutron/recipes/server.rb

@@ -13,8 +13,14 @@
 # limitations under the License.
 #

+zvm_compute_node = search(:node, "roles:nova-compute-zvm") || []
+use_zvm = !zvm_compute_node.empty?


In case the PR gets updated again (no need to update it just for that):

I know it doesn't change anything to the code path here, but for better readability, I would move the node[:neutron][:networking_plugin] == "ml2" test to be part of use_zvm.

houndci-bot · 2016-01-28T09:02:58Z

chef/cookbooks/neutron/recipes/common_agent.rb

@@ -112,6 +115,9 @@
 # ML2 configuration: L2 agent and L3 agent
 if neutron[:neutron][:networking_plugin] == "ml2"
  ml2_mech_drivers = neutron[:neutron][:ml2_mechanism_drivers]
+  if use_zvm && node.roles.include? "nova-compute-zvm"


unexpected token tSTRING
(Using Ruby 2.3 parser; configure using TargetRubyVersion parameter, under AllCops)

Allow deploying with the ZVM L2 driver.

vuntz · 2016-01-28T09:21:52Z

chef/cookbooks/neutron/recipes/server.rb

 pkgs = node[:neutron][:platform][:pkgs] + node[:neutron][:platform][:pkgs_fwaas]
 pkgs += node[:neutron][:platform][:pkgs_lbaas] if node[:neutron][:use_lbaas]
+if use_zvm
+  pkgs << node[:neutron][:platform][:zvm_agent_pkg] if node[:neutron][:networking_plugin] == "ml2"


No need for the if node[:neutron][:networking_plugin] == "ml2" anymore here.

vuntz · 2016-01-28T09:24:17Z

I'm happy to see this merged and I can create a followup PR for the nitpicks if preferred.

+1

aplanas · 2016-01-28T09:34:19Z

LGTM +1

Support installation of Neutron ZVM Driver

vuntz · 2016-01-28T11:50:23Z

I can create a followup PR for the nitpicks if preferred.

#234

rossella · 2016-01-28T15:12:09Z

+1

Remove unused grafana_group from cluster template

* Finish integration of Ansible installer * Set credentials in command line * Fix violations * Fix violations 2 * Add support for multiple networks in single node * Pass missing variables to ansible * Fix hound violations * Use monasca.yml as entry point for ansible installer * Fix paths and influxdb url * Remove agent nodes from inventory file * Remove default grafana config file (crowbar#22) * Fix suse (crowbar#23) * Register monasca endpoints in Keystone * Fix kibana url * Rearrange helper functions * Remove unused group (crowbar#27) * Remove unused grafana_group from cluster template * Disable deprecation_warnings for Ansible (crowbar#34) * They are outputted to STDERR and break applying cookbook. * Address review comments (crowbar#35)

houndci-bot reviewed Sep 14, 2015
View reviewed changes

MaximilianMeister reviewed Sep 16, 2015
View reviewed changes

vuntz added the wip label Sep 23, 2015

dirkmueller force-pushed the s390 branch from 8a65f34 to 910f1d1 Compare October 18, 2015 12:07

dirkmueller force-pushed the s390 branch from 910f1d1 to d248ae3 Compare December 8, 2015 10:27

houndci-bot reviewed Dec 8, 2015
View reviewed changes

dirkmueller force-pushed the s390 branch 4 times, most recently from 2764ed4 to a994df7 Compare December 9, 2015 21:58

houndci-bot reviewed Dec 9, 2015
View reviewed changes

dirkmueller force-pushed the s390 branch 2 times, most recently from 4f7db4e to 9f71e0e Compare December 9, 2015 23:19

dirkmueller removed the wip label Dec 18, 2015

dirkmueller force-pushed the s390 branch from 9f71e0e to e01234e Compare December 18, 2015 16:15

dirkmueller added the wip label Dec 18, 2015

dirkmueller force-pushed the s390 branch from e01234e to 6874020 Compare December 18, 2015 18:15

dirkmueller force-pushed the s390 branch 2 times, most recently from aac4462 to 24aa3ff Compare January 12, 2016 14:51

bmwiedemann reviewed Jan 12, 2016
View reviewed changes

dirkmueller changed the title ~~Support installation of Neutron ZVM Driver [WIP]~~ Support installation of Neutron ZVM Driver Jan 17, 2016

dirkmueller force-pushed the s390 branch from 24aa3ff to 0f1340f Compare January 17, 2016 21:17

dirkmueller force-pushed the s390 branch from 2163281 to 023cfce Compare January 27, 2016 13:03

houndci-bot reviewed Jan 27, 2016
View reviewed changes

dirkmueller force-pushed the s390 branch from 023cfce to 05cc116 Compare January 27, 2016 13:05

toabctl reviewed Jan 27, 2016
View reviewed changes

dirkmueller force-pushed the s390 branch from 05cc116 to 8e913b8 Compare January 27, 2016 15:46

vuntz reviewed Jan 27, 2016
View reviewed changes

dirkmueller force-pushed the s390 branch from 8e913b8 to 6cb1f0b Compare January 28, 2016 09:02

houndci-bot reviewed Jan 28, 2016
View reviewed changes

dirkmueller force-pushed the s390 branch from 6cb1f0b to 03de86b Compare January 28, 2016 09:03

Support installation of Neutron ZVM Driver

4f2800a

Allow deploying with the ZVM L2 driver.

dirkmueller force-pushed the s390 branch from 03de86b to 4f2800a Compare January 28, 2016 09:05

vuntz reviewed Jan 28, 2016
View reviewed changes

vuntz added a commit that referenced this pull request Jan 28, 2016

Merge pull request #27 from dirkmueller/s390

e3028e8

Support installation of Neutron ZVM Driver

vuntz merged commit e3028e8 into crowbar:master Jan 28, 2016

dirkmueller deleted the s390 branch September 14, 2016 12:16

jgrassler pushed a commit to jgrassler/crowbar-openstack that referenced this pull request Mar 27, 2017

Remove unused group (crowbar#27)

873a559

Remove unused grafana_group from cluster template

jgrassler pushed a commit to jgrassler/crowbar-openstack that referenced this pull request Mar 29, 2017

Remove unused group (crowbar#27)

e32a6ac

Remove unused grafana_group from cluster template

jgrassler pushed a commit to jgrassler/crowbar-openstack that referenced this pull request Mar 30, 2017

Remove unused group (crowbar#27)

851d24b

Remove unused grafana_group from cluster template

jgrassler pushed a commit to jgrassler/crowbar-openstack that referenced this pull request Mar 30, 2017

Remove unused group (crowbar#27)

2702dc9

Remove unused grafana_group from cluster template

jgrassler pushed a commit to jgrassler/crowbar-openstack that referenced this pull request Mar 30, 2017

Remove unused group (crowbar#27)

fd75ed6

Remove unused grafana_group from cluster template

dirkmueller pushed a commit to dirkmueller/crowbar-openstack that referenced this pull request Apr 18, 2017

Remove unused group (crowbar#27)

4eb82f3

Remove unused grafana_group from cluster template

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support installation of Neutron ZVM Driver #27

Support installation of Neutron ZVM Driver #27

dirkmueller commented Sep 14, 2015

houndci-bot Sep 14, 2015

tboerger commented Sep 16, 2015

MaximilianMeister Sep 16, 2015

houndci-bot Dec 8, 2015

houndci-bot Dec 9, 2015

bmwiedemann Jan 12, 2016

MaximilianMeister Jan 13, 2016

houndci-bot Jan 27, 2016

toabctl Jan 27, 2016

toabctl commented Jan 27, 2016

vuntz Jan 27, 2016

houndci-bot Jan 28, 2016

vuntz Jan 28, 2016

vuntz commented Jan 28, 2016

aplanas commented Jan 28, 2016

vuntz commented Jan 28, 2016

rossella commented Jan 28, 2016

Support installation of Neutron ZVM Driver #27

Support installation of Neutron ZVM Driver #27

Conversation

dirkmueller commented Sep 14, 2015

Choose a reason for hiding this comment

tboerger commented Sep 16, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

toabctl commented Jan 27, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vuntz commented Jan 28, 2016

aplanas commented Jan 28, 2016

vuntz commented Jan 28, 2016

rossella commented Jan 28, 2016