CI: report error if the generated code has been modified, not generat…

…ed or uncommitted
crowdsecurity · Sep 24, 2024 · b1bab3e · b1bab3e
1 parent 3945a99
commit b1bab3e
Show file tree

Hide file tree

Showing 8 changed files with 20 additions and 57 deletions.
diff --git a/.github/workflows/go-tests.yml b/.github/workflows/go-tests.yml
@@ -128,6 +128,18 @@ jobs:
       with:
         go-version: "1.22"
 
+    - name: Run "make generate" and check for changes
+      run: |
+        set -e
+        make generate 2>/dev/null
+        if [[ $(git status --porcelain) ]]; then
+          echo "Error: Uncommitted changes found after running 'make generate'. Please commit all generated code."
+          git diff
+          exit 1
+        else
+          echo "No changes detected after running 'make generate'."
+        fi
+
     - name: Create localstack streams
       run: |
           aws --endpoint-url=http://127.0.0.1:4566 --region us-east-1 kinesis create-stream --stream-name stream-1-shard --shard-count 1

diff --git a/pkg/database/ent/bouncer/where.go b/pkg/database/ent/bouncer/where.go
diff --git a/pkg/database/ent/bouncer_create.go b/pkg/database/ent/bouncer_create.go
diff --git a/pkg/database/ent/bouncer_update.go b/pkg/database/ent/bouncer_update.go
diff --git a/pkg/database/ent/migrate/schema.go b/pkg/database/ent/migrate/schema.go
diff --git a/pkg/database/ent/mutation.go b/pkg/database/ent/mutation.go
diff --git a/pkg/database/ent/schema/bouncer.go b/pkg/database/ent/schema/bouncer.go
@@ -30,7 +30,7 @@ func (Bouncer) Fields() []ent.Field {
 		field.String("version").Optional().StructTag(`json:"version"`),
 		field.Time("last_pull").Nillable().Optional().StructTag(`json:"last_pull"`),
 		field.String("auth_type").StructTag(`json:"auth_type"`).Default(types.ApiKeyAuthType),
-		field.String("osname").Optional(),
+		field.String("osname"),
 		field.String("osversion").Optional(),
 		field.String("featureflags").Optional(),
 	}

diff --git a/pkg/modelscapi/success_response.go b/pkg/modelscapi/success_response.go