Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make: remove obsolete/redundant parameters #3304

Merged
merged 2 commits into from
Oct 29, 2024
Merged

make: remove obsolete/redundant parameters #3304

merged 2 commits into from
Oct 29, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Oct 29, 2024

No description provided.

@mmetc mmetc added this to the 1.6.4 milestone Oct 29, 2024
@mmetc mmetc requested a review from sabban October 29, 2024 08:36
Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.24%. Comparing base (96d4da7) to head (d891ca6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3304      +/-   ##
==========================================
+ Coverage   58.23%   58.24%   +0.01%     
==========================================
  Files         335      335              
  Lines       37397    37397              
==========================================
+ Hits        21777    21781       +4     
+ Misses      13726    13722       -4     
  Partials     1894     1894              
Flag Coverage Δ
bats 41.41% <ø> (+0.03%) ⬆️
unit-linux 34.00% <ø> (+0.01%) ⬆️
unit-windows 29.24% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc merged commit 97c1f60 into master Oct 29, 2024
18 checks passed
@mmetc mmetc deleted the makefile branch October 29, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants