Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not merge! Credits for DEIS #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

qsh-zh
Copy link

@qsh-zh qsh-zh commented Oct 26, 2022

Hi Katherine,

Thanks for your awesome work. I open the issue to ask for credits of DEIS sampler.

  1. We are actually the first public work that proposes the usage of the exponential integrator method for solving diffusion model ODE, several months easier than concurrent works DPM-solver and Tero's Elucidate work.

Concurrent DPM-Solver~(second order and third order) and Heun method in Elucidate work is in fact exponential RK method with specific underlying RK solvers,

  • DPM-Solver 2 -> second order mid point
  • DPM-Solver 3 -> third order kutta method
  • Heun -> Heun.

Despite different motivations, equation 18 is the key for DPM-Solver and Heun in Elucidate work. And two changes of variables $t <-> \rho$ and $x <->y$ are equivalent to "rescaling" in Elucidate work. And we can use more RK solvers for eq-18. Empirical comparisons among several RK solvers are also included in DEIS.

image

  1. Besides, applying linear multistep with non-uniform step-size and lower order warming started in the transformed ODE is first proposed in DEIS. see $\rho AB$-DEIS.

I know it is a bot area, but it is frustrating to be "scooped" and lose credits for a young researcher. Can you consider some modifications and have some credits for DEIS work?

Thanks,
qsh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant