Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GPoS] Enable Slashing for Staking Module #163

Merged
merged 6 commits into from
Jun 15, 2020
Merged

[GPoS] Enable Slashing for Staking Module #163

merged 6 commits into from
Jun 15, 2020

Conversation

mmyyrroonn
Copy link
Member

@mmyyrroonn mmyyrroonn commented Jun 14, 2020 •
edited
Loading

Fix #134

  • Compared to the init version, slashing module doesn't change much only except for this PR which is used for substrate's new weight mechanism. So I didn't modify this one.
  • Slashing is based on Stakers and Exposure, which we didn't change before. So actually it works well.
  • Tests about slashing are running just like they were in the substrate.

@mmyyrroonn mmyyrroonn requested a review from badkk June 14, 2020 08:08
@mmyyrroonn mmyyrroonn mentioned this pull request Jun 14, 2020
Merged
@badkk badkk changed the title [Gpos] Enable Slashing for Staking Module [GPoS] Enable Slashing for Staking Module Jun 15, 2020
badkk
badkk previously approved these changes Jun 15, 2020
View reviewed changes
cstrml/staking/src/tests.rs Show resolved Hide resolved
cstrml/staking/src/tests.rs Outdated Show resolved Hide resolved
@badkk
Copy link
Contributor

badkk commented Jun 15, 2020

Looks great

@mmyyrroonn mmyyrroonn force-pushed the fix-134-enable-slashing-for-staking branch from 19f7438 to 67ac163 Compare June 15, 2020 10:33
@mmyyrroonn mmyyrroonn merged commit 77453d0 into crustio:master Jun 15, 2020
@mmyyrroonn mmyyrroonn deleted the fix-134-enable-slashing-for-staking branch June 15, 2020 13:13
@badkk badkk added A0-breakconsensus PR which break the consensus, make blocking error maxwell P0-dropeverything🔔 Fix first and removed A0-breakconsensus PR which break the consensus, make blocking error labels Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LowEntropyBody LowEntropyBody LowEntropyBody approved these changes

@badkk badkk badkk approved these changes

Assignees
No one assigned
Labels
P0-dropeverything🔔 Fix first
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[GPoS] Slashing
3 participants
@mmyyrroonn @badkk @LowEntropyBody