Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Market] Add virtual closed status for storage order #185

Merged
merged 8 commits into from
Jul 13, 2020
Merged

[Market] Add virtual closed status for storage order #185

merged 8 commits into from
Jul 13, 2020

Conversation

mmyyrroonn
Copy link
Member

@mmyyrroonn mmyyrroonn commented Jul 9, 2020 •
edited
Loading

Fix #138 Fix #155 Fix #186

  • Add fn close_sorder in market Module
  • Add fn close_sorder in Payment Interface to related payment
  • Add fn close_sorder in MarketInterface
  • In update_identites, close_sorder would be invoked if the sorder is overdue.
  • Full punishment will invoke close_sorder

@mmyyrroonn mmyyrroonn requested a review from badkk July 9, 2020 14:21
@badkk badkk changed the title [Market] Close Order when all pledge are punished [Market] Close Order when the pledge are punished Jul 10, 2020
@badkk badkk changed the title [Market] Close Order when the pledge are punished [Market] Close Order when the pledge is punished Jul 10, 2020
@badkk badkk changed the title [Market] Close Order when the pledge is punished [Market] Close sorder when the pledge is punished Jul 10, 2020
badkk
badkk reviewed Jul 10, 2020
View reviewed changes
cstrml/market/src/lib.rs Outdated Show resolved Hide resolved
cstrml/market/src/lib.rs Outdated Show resolved Hide resolved
cstrml/market/src/lib.rs Outdated Show resolved Hide resolved
cstrml/payment/src/lib.rs Outdated Show resolved Hide resolved
@mmyyrroonn mmyyrroonn force-pushed the fix-138-add-closed-status-for-storage-order branch from bce7874 to 025a19a Compare July 11, 2020 08:59
@mmyyrroonn mmyyrroonn requested a review from badkk July 11, 2020 09:01
mmyyrroonn
mmyyrroonn commented Jul 13, 2020
View reviewed changes
cstrml/tee/src/lib.rs Outdated Show resolved Hide resolved
badkk
badkk reviewed Jul 13, 2020
View reviewed changes
cstrml/tee/src/lib.rs Outdated Show resolved Hide resolved
badkk
badkk reviewed Jul 13, 2020
View reviewed changes
cstrml/tee/src/lib.rs Outdated Show resolved Hide resolved
@badkk badkk changed the title [Market] Close sorder when the pledge is punished [Market] Add virtual closed status for storage order Jul 13, 2020
@mmyyrroonn mmyyrroonn requested a review from badkk July 13, 2020 13:54
@mmyyrroonn mmyyrroonn merged commit c7d8332 into crustio:master Jul 13, 2020
@mmyyrroonn mmyyrroonn deleted the fix-138-add-closed-status-for-storage-order branch July 13, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LowEntropyBody LowEntropyBody LowEntropyBody approved these changes

@badkk badkk badkk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mmyyrroonn @badkk @LowEntropyBody