Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: missing ICA messages in the upgrade plan #905

Merged
merged 3 commits into from
Dec 6, 2022

Conversation

tomtau
Copy link
Contributor

@tomtau tomtau commented Dec 5, 2022

Solution: added the missing staking messages and ICS721 to the allowlist, plus changed the ugprade plan name

Solution: added the missing staking messages and ICS721
to the allowlist, plus changed the ugprade plan name
@tomtau tomtau requested a review from a team as a code owner December 5, 2022 08:50
@tomtau
Copy link
Contributor Author

tomtau commented Dec 5, 2022

/runsim

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Simulation tests started and triggered by /runsim.
Will update here when it succeeds or fails.
Can further check progress here

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #905 (1f1c643) into master (adad502) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #905      +/-   ##
==========================================
- Coverage   16.92%   16.85%   -0.08%     
==========================================
  Files         119      119              
  Lines       14301    13969     -332     
==========================================
- Hits         2420     2354      -66     
+ Misses      11401    11142     -259     
+ Partials      480      473       -7     
Flag Coverage Δ
integration_tests 14.46% <ø> (-0.01%) ⬇️
unit_tests 5.45% <ø> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/app.go 77.56% <ø> (+12.82%) ⬆️
x/nft/client/cli/tx.go 73.87% <0.00%> (-0.32%) ⬇️
app/state.go 0.00% <0.00%> (ø)
x/nft/simulation/operations.go 0.00% <0.00%> (ø)
config/config.go
x/icaauth/types/params.go 50.00% <0.00%> (ø)
x/nft/keeper/querier.go 13.63% <0.00%> (+3.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

/runsim simulation test has succeeded 🎉
Can further check here

Copy link
Contributor

@leejw51crypto leejw51crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tomtau tomtau merged commit 1655bac into crypto-org-chain:master Dec 6, 2022
tomtau added a commit that referenced this pull request Dec 6, 2022
Solution: added the missing staking messages and ICS721
to the allowlist, plus changed the ugprade plan name

* fix upgrade test plan name

* added unjail to the upgrade plan's AllowMessages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants