Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: channel id is not supported for send-to-ibc event #1005

Conversation

thomas-nguy
Copy link
Collaborator

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@thomas-nguy thomas-nguy requested a review from a team as a code owner April 25, 2023 07:44
@thomas-nguy thomas-nguy requested review from yihuang and leejw51crypto and removed request for a team April 25, 2023 07:44
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #1005 (05ee4fc) into main (7a75b41) will increase coverage by 0.06%.
The diff coverage is 42.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1005      +/-   ##
==========================================
+ Coverage   45.25%   45.32%   +0.06%     
==========================================
  Files          80       80              
  Lines        6715     6718       +3     
==========================================
+ Hits         3039     3045       +6     
  Misses       3354     3354              
+ Partials      322      319       -3     
Impacted Files Coverage Δ
x/cronos/keeper/evmhandlers/send_cro_to_ibc.go 58.82% <0.00%> (ø)
x/cronos/keeper/evmhandlers/send_to_ibc.go 39.47% <0.00%> (-2.20%) ⬇️
x/cronos/keeper/evmhandlers/send_to_ibc_v2.go 64.40% <0.00%> (ø)
x/cronos/keeper/msg_server.go 15.27% <0.00%> (-0.44%) ⬇️
x/cronos/keeper/ibc.go 82.08% <78.57%> (+6.17%) ⬆️

x/cronos/keeper/ibc.go Outdated Show resolved Hide resolved
@thomas-nguy thomas-nguy force-pushed the thomas/support-channel-id-for-send-to-ibc branch 2 times, most recently from ab830b5 to 675709c Compare April 27, 2023 07:15
@thomas-nguy thomas-nguy added this pull request to the merge queue Apr 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 28, 2023
@thomas-nguy thomas-nguy added this pull request to the merge queue Apr 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 28, 2023
@thomas-nguy thomas-nguy added this pull request to the merge queue Apr 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 28, 2023
@thomas-nguy thomas-nguy added this pull request to the merge queue May 1, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 1, 2023
@thomas-nguy thomas-nguy added this pull request to the merge queue May 2, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 2, 2023
@thomas-nguy thomas-nguy force-pushed the thomas/support-channel-id-for-send-to-ibc branch from 675709c to e7c2867 Compare May 2, 2023 05:41
@thomas-nguy thomas-nguy enabled auto-merge May 2, 2023 05:41
@thomas-nguy thomas-nguy force-pushed the thomas/support-channel-id-for-send-to-ibc branch from e7c2867 to eeca889 Compare May 2, 2023 09:07
@thomas-nguy thomas-nguy added this pull request to the merge queue May 3, 2023
Merged via the queue into crypto-org-chain:main with commit 6765a82 May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants