-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: channel id is not supported for send-to-ibc event #1005
Merged
thomas-nguy
merged 6 commits into
crypto-org-chain:main
from
thomas-nguy:thomas/support-channel-id-for-send-to-ibc
May 3, 2023
Merged
Problem: channel id is not supported for send-to-ibc event #1005
thomas-nguy
merged 6 commits into
crypto-org-chain:main
from
thomas-nguy:thomas/support-channel-id-for-send-to-ibc
May 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-nguy
requested review from
yihuang and
leejw51crypto
and removed request for
a team
April 25, 2023 07:44
Codecov Report
@@ Coverage Diff @@
## main #1005 +/- ##
==========================================
+ Coverage 45.25% 45.32% +0.06%
==========================================
Files 80 80
Lines 6715 6718 +3
==========================================
+ Hits 3039 3045 +6
Misses 3354 3354
+ Partials 322 319 -3
|
mmsqe
reviewed
Apr 26, 2023
thomas-nguy
force-pushed
the
thomas/support-channel-id-for-send-to-ibc
branch
2 times, most recently
from
April 27, 2023 07:15
ab830b5
to
675709c
Compare
mmsqe
approved these changes
Apr 27, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Apr 28, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Apr 28, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Apr 28, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
May 1, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
May 2, 2023
thomas-nguy
force-pushed
the
thomas/support-channel-id-for-send-to-ibc
branch
from
May 2, 2023 05:41
675709c
to
e7c2867
Compare
thomas-nguy
force-pushed
the
thomas/support-channel-id-for-send-to-ibc
branch
from
May 2, 2023 09:07
e7c2867
to
eeca889
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)