Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: local state-sync commands are not integrated #1027

Merged
merged 14 commits into from
May 16, 2023

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented May 15, 2023

  • integrate commands
  • write integration test

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang yihuang added the backport/v1.0.x backport to release/v1.0.x label May 15, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #1027 (1ad1ba6) into main (0d5bf68) will increase coverage by 0.34%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1027      +/-   ##
==========================================
+ Coverage   45.82%   46.17%   +0.34%     
==========================================
  Files          82       82              
  Lines        6937     6937              
==========================================
+ Hits         3179     3203      +24     
+ Misses       3422     3397      -25     
- Partials      336      337       +1     
Impacted Files Coverage Δ
memiavl/db.go 54.30% <0.00%> (ø)
app/memiavl.go 100.00% <100.00%> (+80.00%) ⬆️

... and 1 file with indirect coverage changes

@yihuang yihuang marked this pull request as ready for review May 15, 2023 08:27
@yihuang yihuang requested a review from a team as a code owner May 15, 2023 08:27
@yihuang yihuang requested review from JayT106, devashishdxt and mmsqe and removed request for a team May 15, 2023 08:27
Copy link
Collaborator

@mmsqe mmsqe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might need add rpc_servers as well

integration_tests/cosmoscli.py Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
Co-authored-by: mmsqe <[email protected]>
Signed-off-by: yihuang <[email protected]>
mmsqe added 2 commits May 16, 2023 11:42
for f in $(find . -name go.mod)
do (cd $(dirname $f); go mod tidy)
done
@yihuang yihuang requested a review from mmsqe May 16, 2023 06:49
@yihuang yihuang enabled auto-merge May 16, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v1.0.x backport to release/v1.0.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants