Problem: memiavl don't recover corrupted wal tail #1073
Conversation
Solution: - fix in wal and update dependencies
Codecov Report
@@ Coverage Diff @@
## main #1073 +/- ##
==========================================
- Coverage 46.53% 46.13% -0.40%
==========================================
Files 81 82 +1
Lines 7135 7203 +68
==========================================
+ Hits 3320 3323 +3
- Misses 3462 3522 +60
- Partials 353 358 +5
|
Signed-off-by: yihuang <[email protected]>
yihuang
force-pushed
the
wal-recover-tail
branch
from
9c0486e
to
8c9df59
Compare
Signed-off-by: yihuang <[email protected]>
yihuang
requested review from
JayT106 and
calvinaco
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if uint64(len(data)-n) < size { | ||
| return 0, wal.ErrCorrupt | ||
| } | ||
| return n + int(size), nil |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
| if n <= 0 { | ||
| return 0, wal.ErrCorrupt | ||
| } | ||
| if uint64(len(data)-n) < size { |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
| "io/ioutil" | ||
| "os" | ||
| "path/filepath" | ||
| "unsafe" |
Check failure
Code scanning / gosec
Blocklisted import unsafe
| return 0, wal.ErrCorrupt | ||
| } | ||
| line := data[:idx] | ||
| dres := gjson.Get(*(*string)(unsafe.Pointer(&line)), "data") |
Check warning
Code scanning / gosec
Use of unsafe calls should be audited
| "io/ioutil" | ||
| "os" | ||
| "path/filepath" | ||
| "unsafe" |
Check notice
Code scanning / CodeQL
Sensitive package import
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)