Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: memiavl root hash not compatible with sdk 47 #1083

Merged
merged 5 commits into from
Jun 29, 2023

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Jun 26, 2023

Solution:

  • add parameter to support both

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Solution:
- add parameter to support both
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: yihuang <[email protected]>
app/app.go Outdated Show resolved Hide resolved
@yihuang yihuang marked this pull request as ready for review June 29, 2023 03:24
@yihuang yihuang requested a review from a team as a code owner June 29, 2023 03:24
@yihuang yihuang requested review from mmsqe and devashishdxt and removed request for a team June 29, 2023 03:24
@mmsqe mmsqe enabled auto-merge June 29, 2023 03:31
store/rootmulti/store.go Outdated Show resolved Hide resolved
@mmsqe mmsqe added this pull request to the merge queue Jun 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 29, 2023
@mmsqe mmsqe added this pull request to the merge queue Jun 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 29, 2023
@mmsqe mmsqe added this pull request to the merge queue Jun 29, 2023
Merged via the queue into crypto-org-chain:main with commit d75ed1a Jun 29, 2023
24 checks passed
@yihuang yihuang deleted the sdk47 branch June 30, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants