Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: LastCommitID crashes when memiavl is not loaded first #1087

Merged
merged 4 commits into from
Jun 29, 2023

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Jun 28, 2023

Solution:

  • support the use case used by x/upgrade

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Solution:
- support the use case used by x/upgrade
@yihuang yihuang requested a review from a team as a code owner June 28, 2023 09:01
@yihuang yihuang requested review from calvinaco and thomas-nguy and removed request for a team June 28, 2023 09:01
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: yihuang <[email protected]>
@yihuang yihuang requested a review from mmsqe June 28, 2023 09:05
if err != nil {
return 0, err
}
return walVersion(lastIndex, uint32(metadata.InitialVersion)), nil

Check failure

Code scanning / gosec

Potential integer overflow by integer type conversion Error

Potential integer overflow by integer type conversion
memiavl/multitree.go Outdated Show resolved Hide resolved
Co-authored-by: mmsqe <[email protected]>
Signed-off-by: yihuang <[email protected]>
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #1087 (04f8f06) into main (6ffbced) will decrease coverage by 0.05%.
The diff coverage is 34.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1087      +/-   ##
==========================================
- Coverage   46.20%   46.15%   -0.05%     
==========================================
  Files          80       80              
  Lines        7173     7197      +24     
==========================================
+ Hits         3314     3322       +8     
- Misses       3502     3518      +16     
  Partials      357      357              
Impacted Files Coverage Δ
memiavl/db.go 55.24% <18.18%> (-1.81%) ⬇️
memiavl/multitree.go 72.53% <52.63%> (+0.59%) ⬆️

@yihuang yihuang requested a review from mmsqe June 28, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants