-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
embed gravity bridge module #11
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ccd039f
embed gravity bridge module
yihuang a598bc3
better to keep the sdk compatible gentx command
yihuang 84a2376
add tool to sign validator msg
yihuang c600716
update chain-id
yihuang 2870161
fix keeper initialization order
yihuang 1733fd0
build patched orchestrator
yihuang 297fe70
orchestrator support EthAccount
yihuang 106ed59
fix changelog order
yihuang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
#!/usr/bin/env python | ||
import getpass | ||
from pathlib import Path | ||
|
||
import eth_utils | ||
import fire | ||
from cprotobuf import Field, ProtoEntity | ||
from eth_account import Account | ||
from eth_account.messages import encode_defunct | ||
|
||
|
||
class DelegateKeysSignMsg(ProtoEntity): | ||
validator_address = Field("string", 1) | ||
nonce = Field("uint64", 2) | ||
|
||
|
||
class CLI: | ||
def sign_validator( | ||
self, keystore: str, validator_address: str, nonce: int, passphrase=None | ||
): | ||
if passphrase is None: | ||
passphrase = getpass.getpass("keystore passphrase:") | ||
key = Account.decrypt(Path(keystore).read_text(), passphrase) | ||
acct = Account.from_key(key) | ||
msg = DelegateKeysSignMsg(validator_address=validator_address, nonce=nonce) | ||
sign_bytes = eth_utils.keccak(msg.SerializeToString()) | ||
|
||
signed = acct.sign_message(encode_defunct(sign_bytes)) | ||
return eth_utils.to_hex(signed.signature) | ||
|
||
def decrypt_keystore(self, keystore: str, passphrase=None): | ||
if passphrase is None: | ||
passphrase = getpass.getpass("keystore passphrase:") | ||
return Account.decrypt(Path(keystore).read_text(), passphrase).hex() | ||
|
||
|
||
if __name__ == "__main__": | ||
fire.Fire(CLI()) |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why changing this? in 0.43, there are 32-byte addresses (e.g. if one uses a different signing algorithm)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/PeggyJV/gravity-bridge/blob/main/module/app/app.go#L104
gravity seems to require this, not sure if it works without it. I guess it need to map any potential cosmos address to ethereum.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PeggyJV/gravity-bridge#143
Opened issue to gravity, I guess it's possible to only do the verification at module level.