-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: swagger doc is not embed in api service #110
Conversation
Codecov Report
@@ Coverage Diff @@
## main #110 +/- ##
==========================================
+ Coverage 21.51% 25.76% +4.24%
==========================================
Files 27 34 +7
Lines 1729 2267 +538
==========================================
+ Hits 372 584 +212
- Misses 1324 1643 +319
- Partials 33 40 +7
Continue to review full report at Codecov.
|
Closes: crypto-org-chain#108 Soluton: - register swagger service in app - add swagger gen scripts only lint our own proto files, add proto-swagger-gen to CI fix protobuf lint fix protogen gomod2nix install statik in script pin statik version try to fix CI error rebase changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Closes: #108
Soluton:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)