Problem: feeibc, evm and feemarket gensis migrate is broken #1124
Conversation
…rypto-org-chain#1125) * Problem: feeibc, evm and feemarket gensis migrate is broken * make use of sdk * add test * fix gravity genesis * update deps * add change doc * update deps * Update CHANGELOG.md Co-authored-by: yihuang <[email protected]> Signed-off-by: mmsqe <[email protected]> --------- Signed-off-by: mmsqe <[email protected]> Co-authored-by: yihuang <[email protected]>
mmsqe
force-pushed
the
release/v1.0.x-migrate-gen
branch
from
b10c2ee
to
e76a2cc
Compare
mmsqe
requested review from
devashishdxt and
leejw51crypto
and removed request for
a team
|
It seems like migration is still not working with this commit: trying to migrate 0.43 to 0.46 genesis.json
cronosd migrate v0.46 genesis.json > genesis46_new.json
rm -r genesis.json cronosd validate-genesis --trace |
Have you try |
Yes, thank you, command worked for migration process, however validation of migrated json still return error: cronosd validate-genesis --trace Error: error validating genesis file /root/.cronos/config/genesis.json: failed to unmarshal cronos genesis state: EOF |
|
If some field were absent at all because it was not cronos exported - can it be an issue here? |
|
This is the error upon cronosd start |
Not sure which fields you mean, do you see |
No such field (after conversion with suggested v1 command).
Besides this update handlers way there is also a manual way: Ive made a script that parse only structure of big genesis.json (cut repeating sequences and value, leave only keys structures). Is there a place to download any cronos state to compare it with genesisL1 state and fix differences? I can also provide v1 converted state as it is now. |
|
So here are 2 files:
http://142.44.143.79/genesis_v1_converted_pretty.json Now need to manually compare keys structure with cronos genesis.json (or state exported genesis.json) structure and get out of diffs. |
|
genesis.json of cronos mainnet also not have |
|
Just in case, cronos latest state: |
|
So far found:
"intrarelayer": {
Which is presented in cronos |
|
Not exactly clear:
And cronos have it filled with stuff |
|
We have a colossal mismatch in gov module structure: Cronos gov: GenesisL1 gov: |
|
Mismatch in gov proposal structure: CRONOS GENESISL1 |
|
What is an "authority" field? is it someone who submit proposal? |
|
Seems like all diffs fixed and got this weird big.INT bug |
Adding min_commission_rate to staking params and still have that issue. Field copied from exported cronos state. |
|
@alpha-omega-labs I see some patch patterns like add missing or cast wrong type, but might take the risk when modify since cronos genesis is valid. |
Thank you very much for your help! I will try those in a few hours! But is this one 8d56138 for export or also for migration? Also question about gov structure - it totally different. I will fix it with custom python script to match cronos format, but is this an issue? For now just deleted gov module state to concentrate on this stake space problem with min_commission_rate. Another question - may it be related to denom somewhere in state? I see its "stake" in many places in cronos genesis.json and we have "el1" everywhere. I can't figure out why it comes as "types.Dec.IsNegative(...)" in no place its negative and its actually default "0" - exact same as in cronos genesis.json I will provide migrated and updated genesis.json with all fixes to date and gov ommited, maybe you will see something else that don't allow validation. Anyways, really appreciate your help and time with this, it really matter! |
Migration command with those 2 commits fail: |
|
Some weird part: What can be the reason? Its literally nothing changed there after export and binary is original cronosd but with cometbft changed to allow big genesis.json by disabling compression. |
|
Do you know the way to address this cosmos/cosmos-sdk#17250 |
|
Aside from gov module everything since to be valid atm, thank you very much for help again! Can you please tell what is an |
Found it - its a gov module address, BTW! its same for all networks, just prefix different. |
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
Closes: #1122
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)