-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: interchain-accounts in ibc-go v6 is not integrated #1147
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1147 +/- ##
===========================================
+ Coverage 24.08% 46.37% +22.29%
===========================================
Files 47 105 +58
Lines 2940 7855 +4915
===========================================
+ Hits 708 3643 +2935
- Misses 2162 3837 +1675
- Partials 70 375 +305
|
x/icaauth/keeper/keeper.go
Outdated
// timeoutDuration should be constraited by MinTimeoutDuration parameter. | ||
timeoutTimestamp := ctx.BlockTime().Add(timeoutDuration).UnixNano() | ||
|
||
_, err = k.icaControllerKeeper.SendTx(ctx, channelCapability, connectionID, portID, packetData, uint64(timeoutTimestamp)) |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion Error
|
||
// String implements the Stringer interface. | ||
func (p Params) String() string { | ||
out, _ := yaml.Marshal(p) // nolint:errcheck |
Check warning
Code scanning / gosec
Returned error is not propagated up the stack. Warning
265459d
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)