Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: interchain-accounts in ibc-go v6 is not integrated #1147

Merged
merged 5 commits into from
Aug 31, 2023

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Aug 29, 2023

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #1147 (465f4ef) into main (05b31c6) will increase coverage by 22.29%.
The diff coverage is 34.09%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1147       +/-   ##
===========================================
+ Coverage   24.08%   46.37%   +22.29%     
===========================================
  Files          47      105       +58     
  Lines        2940     7855     +4915     
===========================================
+ Hits          708     3643     +2935     
- Misses       2162     3837     +1675     
- Partials       70      375      +305     
Files Changed Coverage Δ
app/upgrades.go 15.00% <0.00%> (-7.23%) ⬇️
x/cronos/client/cli/tx.go 55.41% <0.00%> (-1.05%) ⬇️
x/icaauth/genesis.go 0.00% <0.00%> (ø)
...th/keeper/grpc_query_interchain_account_address.go 0.00% <0.00%> (ø)
x/icaauth/keeper/grpc_query_params.go 0.00% <0.00%> (ø)
x/icaauth/keeper/msg_server_register_account.go 0.00% <0.00%> (ø)
x/icaauth/keeper/msg_server_submit_tx.go 0.00% <0.00%> (ø)
x/icaauth/keeper/params.go 0.00% <0.00%> (ø)
x/icaauth/types/message_submit_tx.go 10.52% <10.52%> (ø)
x/icaauth/module_ibc.go 12.50% <12.50%> (ø)
... and 15 more

... and 50 files with indirect coverage changes

integration_tests/test_ibc.py Outdated Show resolved Hide resolved
x/icactl/keeper/msg_server.go Fixed Show fixed Hide fixed
x/icactl/client/cli/tx.go Fixed Show fixed Hide fixed
x/icactl/client/cli/tx.go Fixed Show fixed Hide fixed
@mmsqe mmsqe marked this pull request as ready for review August 30, 2023 10:13
@mmsqe mmsqe requested a review from a team as a code owner August 30, 2023 10:13
@mmsqe mmsqe requested review from yihuang and thomas-nguy and removed request for a team August 30, 2023 10:13
// timeoutDuration should be constraited by MinTimeoutDuration parameter.
timeoutTimestamp := ctx.BlockTime().Add(timeoutDuration).UnixNano()

_, err = k.icaControllerKeeper.SendTx(ctx, channelCapability, connectionID, portID, packetData, uint64(timeoutTimestamp))

Check failure

Code scanning / gosec

Potential integer overflow by integer type conversion Error

Potential integer overflow by integer type conversion

// String implements the Stringer interface.
func (p Params) String() string {
out, _ := yaml.Marshal(p) // nolint:errcheck

Check warning

Code scanning / gosec

Returned error is not propagated up the stack. Warning

Returned error is not propagated up the stack.
@mmsqe mmsqe added this pull request to the merge queue Aug 31, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 31, 2023
@mmsqe mmsqe added this pull request to the merge queue Aug 31, 2023
Merged via the queue into crypto-org-chain:main with commit 265459d Aug 31, 2023
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants