Problem: memiavl api don't work with FinalizeBlock #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
FinalizeBlock in abci 2.0 need the WorkingHash API. Solution: - redesign the internals APIs to support WorkingHash. instead of exposing a single `Commit` API, now we exposes separate APIs for `ApplyChangeSets` and `Commit`.
yihuang
requested review from
mmsqe and
devashishdxt
and removed request for
a team
Comment on lines
+109
to
+113
| for _, store := range rs.stores { | ||
| if store.GetStoreType() != types.StoreTypeIAVL { | ||
| _ = store.Commit() | ||
| } | ||
| } |
Check failure
Code scanning / gosec
the value in the range statement should be _ unless copying a map: want: for key := range m Error
Comment on lines
+109
to
+113
| for _, store := range rs.stores { | ||
| if store.GetStoreType() != types.StoreTypeIAVL { | ||
| _ = store.Commit() | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1149 +/- ##
==========================================
+ Coverage 46.43% 46.54% +0.11%
==========================================
Files 105 105
Lines 7859 7923 +64
==========================================
+ Hits 3649 3688 +39
- Misses 3837 3856 +19
- Partials 373 379 +6
|
mmsqe
reviewed
Aug 31, 2023
mmsqe
reviewed
Aug 31, 2023
mmsqe
approved these changes
Aug 31, 2023
yzang2019
reviewed
Aug 31, 2023
yihuang
force-pushed
the
working-hash
branch
from
98e3653
to
777e574
Compare
yzang2019
approved these changes
Sep 1, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Signed-off-by: yihuang <[email protected]>
Merged
via the queue into
crypto-org-chain:main
with commit Sep 1, 2023
04b26e4
23 of 24 checks passed
13 tasks
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FinalizeBlock in abci 2.0 need the WorkingHash API.
Solution:
CommitAPI, now we exposes separate APIs forApplyChangeSetsandCommit.👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)