Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: gravity module is not ready to release #1187

Merged
merged 8 commits into from
Sep 27, 2023

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Sep 27, 2023

Solution:

  • set skipGravity to true, and remove from upgrade handler

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Solution:
- set skipGravity to true, and remove from upgrade handler
@yihuang yihuang requested a review from a team as a code owner September 27, 2023 08:58
@yihuang yihuang requested review from calvinaco and devashishdxt and removed request for a team September 27, 2023 08:58
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: yihuang <[email protected]>
@yihuang yihuang requested a review from mmsqe September 27, 2023 09:18
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #1187 (c625107) into main (aee4960) will increase coverage by 10.92%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1187       +/-   ##
===========================================
+ Coverage   37.28%   48.21%   +10.92%     
===========================================
  Files         115       74       -41     
  Lines       10169     6187     -3982     
===========================================
- Hits         3792     2983      -809     
+ Misses       5994     2887     -3107     
+ Partials      383      317       -66     
Files Coverage Δ
app/upgrades.go 50.00% <ø> (+2.17%) ⬆️

... and 53 files with indirect coverage changes

Copy link
Collaborator

@thomas-nguy thomas-nguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm even though there is no need to remove it from the app as the bridge will be disabled by default with the consensus parameters
bridge_active": False

@mmsqe mmsqe added this pull request to the merge queue Sep 27, 2023
Merged via the queue into crypto-org-chain:main with commit 2dd9c8b Sep 27, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants