-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: gravity module is not ready to release #1187
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: - set skipGravity to true, and remove from upgrade handler
yihuang
requested review from
calvinaco and
devashishdxt
and removed request for
a team
September 27, 2023 08:58
yihuang
commented
Sep 27, 2023
Signed-off-by: yihuang <[email protected]>
Signed-off-by: yihuang <[email protected]>
mmsqe
approved these changes
Sep 27, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1187 +/- ##
===========================================
+ Coverage 37.28% 48.21% +10.92%
===========================================
Files 115 74 -41
Lines 10169 6187 -3982
===========================================
- Hits 3792 2983 -809
+ Misses 5994 2887 -3107
+ Partials 383 317 -66
|
calvinaco
approved these changes
Sep 27, 2023
thomas-nguy
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm even though there is no need to remove it from the app as the bridge will be disabled by default with the consensus parameters
bridge_active": False
Signed-off-by: mmsqe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)