Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: ethermint is not updated #1215

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Oct 19, 2023

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: mmsqe <[email protected]>
@mmsqe mmsqe marked this pull request as ready for review October 19, 2023 01:57
@mmsqe mmsqe requested a review from a team as a code owner October 19, 2023 01:57
@mmsqe mmsqe requested review from yihuang and JayT106 and removed request for a team October 19, 2023 01:57
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #1215 (75af523) into main (94b98ed) will increase coverage by 20.25%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1215       +/-   ##
===========================================
+ Coverage   16.70%   36.95%   +20.25%     
===========================================
  Files          79      115       +36     
  Lines        5766    10235     +4469     
===========================================
+ Hits          963     3782     +2819     
- Misses       4725     6080     +1355     
- Partials       78      373      +295     
Files Coverage Δ
memiavl/db.go 59.93% <100.00%> (ø)
memiavl/import.go 70.55% <100.00%> (ø)

... and 52 files with indirect coverage changes

go.mod Show resolved Hide resolved
Copy link
Collaborator

@thomas-nguy thomas-nguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

is it going to be part of the next release or bug fix for the upcoming release?

@mmsqe
Copy link
Collaborator Author

mmsqe commented Oct 20, 2023

lgtm

is it going to be part of the next release or bug fix for the upcoming release?

maybe just as a bug fix, but not sure if we need back port to v1.0.x @yihuang

@mmsqe mmsqe enabled auto-merge October 23, 2023 10:59
@mmsqe mmsqe added this pull request to the merge queue Oct 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 23, 2023
@mmsqe mmsqe added this pull request to the merge queue Oct 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 23, 2023
@mmsqe mmsqe added this pull request to the merge queue Oct 23, 2023
Merged via the queue into crypto-org-chain:main with commit 44d0284 Oct 23, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants