Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: debug_traceCall is not supported #1287

Merged
merged 4 commits into from
Jan 5, 2024

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Jan 5, 2024

  • add debug_traceCall

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

  • New Features

    • Introduced support for debug_traceCall to enhance debugging capabilities.
    • Implemented updates for hard-fork style upgrades.
  • Improvements

    • Upgraded compatibility with ethermint and cosmos-sdk.
    • Enabled push0 opcode in integration tests.
  • Removals

    • Removed the authz module for streamlined functionality.

@yihuang yihuang requested a review from a team as a code owner January 5, 2024 07:00
@yihuang yihuang requested review from mmsqe and leejw51crypto and removed request for a team January 5, 2024 07:00
Copy link
Contributor

coderabbitai bot commented Jan 5, 2024

Walkthrough

The change introduces support for debug_traceCall and includes updates related to hard-fork style upgrades, ethermint, cosmos-sdk, enabling push0 opcode in integration test, and removing the authz module. Additionally, modifications to the error handling and assertion logic within the test_failed_transfer_tx function have been made.

Changes

Files Change Summary
CHANGELOG.md, integration_tests/test_basic.py Introduces support for debug_traceCall, updates related to hard-fork style upgrades, ethermint, cosmos-sdk, enabling push0 opcode in integration test, and removing the authz module. Modifications to error handling and assertion logic in test_failed_transfer_tx.

🐇✨
To code's vast meadow, a new dawn arrives,
With traceCall to debug our digital lives.
Hard-forks and cosmos, in harmony they blend,
Farewell authz, this is the end.
🌟🚀

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit's AI:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
    • @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: yihuang <[email protected]>
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 2

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 86ad7b3 and aab911c.
Files ignored due to filter (3)
  • go.mod
  • go.sum
  • gomod2nix.toml
Files selected for processing (1)
  • CHANGELOG.md (1 hunks)

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: mmsqe <[email protected]>
Signed-off-by: yihuang <[email protected]>
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between aab911c and 024c781.
Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • CHANGELOG.md

@yihuang yihuang enabled auto-merge January 5, 2024 07:05
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 024c781 and 1b2e93b.
Files selected for processing (1)
  • integration_tests/test_basic.py (1 hunks)
Additional comments: 3
integration_tests/test_basic.py (3)
  • 746-746: The change on line 746 modifies the RPC call to use a list comprehension for tx_hashes. This is a more Pythonic way of making multiple requests and is a good change.

  • 749-752: The logic on lines 749-752 checks if the transaction was successful and then asserts that the debug_traceTransaction did not fail and that the gas used matches. This is a correct way to verify the success of a transaction.

  • 753-760: The error handling from lines 753-760 checks if the transaction failed and asserts that the error message matches the expected one. This is a good practice as it verifies the correct error is thrown for a failed transaction. However, it's important to ensure that the error message is consistent with the actual error messages returned by the system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants