Problem: latest hermes is not used in integration tests

[mmsqe]

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

• Have you read the CONTRIBUTING.md?
• Does your PR follow the C4 patch requirements?
• Have you rebased your work on top of the latest master?
• Have you checked your code compiles? (make)
• Have you included tests for any non-trivial functionality?
• Have you checked your code passes the unit tests? (make test)
• Have you checked your code formatting is correct? (go fmt)
• Have you checked your basic code style is fine? (golangci-lint run)
• If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
• If your changes affect the client infrastructure, have you run the integration test?
• If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
• If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
• If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

• New Features

  • Introduced a new configuration for event sourcing with a batch delay setting.
  • Added functionality to automatically download and install the Hermes tool based on system architecture.

• Refactor

  • Modified the call to Hermes in the configuration, enhancing setup and integration processes.

[coderabbitai]

Walkthrough

The changes involve enhancing an IBC (Inter-Blockchain Communication) configuration with an event_source parameter and a batch_delay setting, updating the process for downloading and installing the Hermes tool from Informal Systems based on system architecture, and refining the way Hermes is called within the project setup. These modifications aim to improve blockchain communication efficiency and streamline the tool's integration and usage.

Changes

File Path	Change Summary
.../configs/ibc.jsonnet	Added event_source with batch_delay: '5000ms' to the config section for specified price points.
integration_tests/.../hermes.nix	Introduces functionality to download, extract, and install Hermes based on system architecture.
nix/default.nix	Modified Hermes call, now utilizing ../integration_tests/install_hermes.nix without a source reference.

🐇💻✨
In the realm of code, where the rabbits dwell,
Changes afoot, with tales to tell.
Hermes arrives, swift and keen,
Across the chains, unseen, unseen.
Batches delay, as events take flight,
In the digital burrow, all through the night.
🌙🚀🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 3

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 0d86538 and 6157522.

Files ignored due to path filters (1)

• nix/sources.json is excluded by: !**/*.json

Files selected for processing (3)

• integration_tests/configs/ibc.jsonnet (2 hunks)
• integration_tests/install_hermes.nix (1 hunks)
• nix/default.nix (1 hunks)

Additional comments: 5

integration_tests/install_hermes.nix (2)

• 6-18: The URLs for downloading Hermes binaries are constructed using the version variable, which is good for maintainability. However, ensure that the SHA256 hashes are verified against a trusted source to prevent the risk of downloading compromised binaries.
• 20-21: The error handling for unsupported systems is clear and straightforward. This is a good practice as it provides immediate feedback to the user if their system is not supported.

nix/default.nix (1)

• 42-42: The modification to call hermes using the new install_hermes.nix script is aligned with the PR's objective. Ensure that this change has been tested across all supported platforms to verify that Hermes is correctly installed and integrated into the build process.

integration_tests/configs/ibc.jsonnet (2)

• 158-160: The addition of event_source with a batch_delay of 5000ms is a clear and straightforward way to configure event handling. Ensure that this delay value has been chosen based on empirical evidence or testing to optimize event sourcing without causing unnecessary delays in the integration tests.
• 173-175: The same event_source configuration is applied to another gas price setting, maintaining consistency in the handling of events across different configurations. This consistency is good practice, but again, verify that the batch_delay value is optimal for this context as well.