Problem: ethermint is outdated #1363
Conversation
WalkthroughThe changes in version Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
mmsqe
requested review from
yihuang and
leejw51crypto
and removed request for
a team
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (3)
go.modis excluded by:!**/*.modgo.sumis excluded by:!**/*.sumgomod2nix.tomlis excluded by:!**/*.toml
Files selected for processing (1)
- CHANGELOG.md (1 hunks)
Files not reviewed due to errors (1)
- CHANGELOG.md (Error: unable to parse review)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1363 +/- ##
=======================================
Coverage 36.71% 36.71%
=======================================
Files 108 108
Lines 9642 9642
=======================================
Hits 3540 3540
Misses 5753 5753
Partials 349 349
|
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files ignored due to path filters (3)
go.modis excluded by:!**/*.modgo.sumis excluded by:!**/*.sumgomod2nix.tomlis excluded by:!**/*.toml
Files selected for processing (4)
- CHANGELOG.md (1 hunks)
- app/app.go (2 hunks)
- app/encoding.go (1 hunks)
- cmd/cronosd/cmd/root.go (4 hunks)
Additional comments: 6
app/encoding.go (1)
- 9-9: The change in the return type of
MakeEncodingConfigtoethermint.EncodingConfigaligns with the PR's objective to update Ethermint. Ensure that all integrations and usages of this function are updated to handle the new return type correctly.cmd/cronosd/cmd/root.go (3)
- 58-58: The update to the return type of
NewRootCmdtoethermint.EncodingConfigis consistent with the PR's objective. Ensure that all integrations and usages of this function are updated to handle the new return type correctly.- 112-112: The update to the parameter type of
initRootCmdtoethermint.EncodingConfigis consistent with the PR's objective. Ensure that all integrations and usages of this function are updated to handle the new parameter type correctly.- 237-237: The update to the field type of
encCfgin theappCreatorstruct toethermint.EncodingConfigis consistent with the PR's objective. Ensure that all integrations and usages of this struct are updated to handle the new field type correctly.app/app.go (2)
- 12-17: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-377]
Ensure that the removal of the
appparamsimport does not lead to unresolved references elsewhere in the codebase. This change should be part of a broader refactoring to useethermintfor encoding configurations.Verification successful
The removal of the
appparamsimport fromapp/app.godoes not affect the references found inx/cronos/simulation/operations.goandx/cronos/migrations/v2/migrate_test.go. These references are for simulation and testing purposes and use a different import path (cosmossdk.io/simapp/params), indicating that they are unrelated to the main application configuration changes. Therefore, the initial review comment stands, with the recommendation to ensure that the removal ofappparamsdoes not lead to unresolved references or a loss of functionality in the context of the main application configuration.* 375-375: The `encodingConfig` parameter type in the `New` function has been changed from `appparams.EncodingConfig` to `ethermint.EncodingConfig`. Verify that all callers of this function have been updated to use the new type and ensure that `ethermint.EncodingConfig` provides all necessary functionalities previously covered by `appparams.EncodingConfig`.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for any remaining references to `appparams` that might be unresolved. rg "appparams"Length of output: 366
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (3)
go.modis excluded by:!**/*.modgo.sumis excluded by:!**/*.sumgomod2nix.tomlis excluded by:!**/*.toml
Files selected for processing (4)
- CHANGELOG.md (1 hunks)
- app/app.go (2 hunks)
- app/encoding.go (1 hunks)
- cmd/cronosd/cmd/root.go (4 hunks)
Files skipped from review as they are similar to previous changes (3)
- app/app.go
- app/encoding.go
- cmd/cronosd/cmd/root.go
Additional comments: 1
CHANGELOG.md (1)
- 13-13: Consider capitalizing "ethermint" to "Ethermint" for consistency throughout the document.
a300760
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)
Summary by CodeRabbit
gasUsedattribute in the RPC API for improved stability.