Problem: parallel tx execution not integrated #1377
Conversation
|
Important Auto Review SkippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 121 files out of 182 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| for key := range rs.listeners { | ||
| ls := rs.listeners[key] | ||
| if ls != nil { | ||
| cache = append(cache, ls.PopStateCache()...) | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
| for _, key := range app.keys { | ||
| keys = append(keys, key) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
| for _, key := range app.tkeys { | ||
| keys = append(keys, key) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
| for _, key := range app.memKeys { | ||
| keys = append(keys, key) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
| for _, key := range app.okeys { | ||
| keys = append(keys, key) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
| for _, m := range app.ModuleManager.Modules { | ||
| if moduleWithName, ok := m.(module.HasName); ok { | ||
| moduleName := moduleWithName.Name() | ||
| if appModule, ok := moduleWithName.(appmodule.AppModule); ok { | ||
| modules[moduleName] = appModule | ||
| } | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
| for _, k := range storeKeys { | ||
| stores[k] = NewKVStore(versionDB, k, nil) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1377 +/- ##
===========================================
+ Coverage 16.47% 35.42% +18.95%
===========================================
Files 80 123 +43
Lines 5124 9422 +4298
===========================================
+ Hits 844 3338 +2494
- Misses 4204 5727 +1523
- Partials 76 357 +281
|
yihuang
requested review from
mmsqe and
devashishdxt
and removed request for
a team
yihuang
force-pushed
the
block-stm
branch
5 times, most recently
from
ff5f2d6
to
bcec245
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
yihuang
force-pushed
the
block-stm
branch
2 times, most recently
from
ff1f018
to
455f90e
Compare
Solution: - update ethermint and dependencies - fix sdk 50 integration Co-authored-by: mmsqe <[email protected]> Signed-off-by: yihuang <[email protected]> recover client for more info, cosmos/ibc-go#3674 fix ibc for more info, https://ibc.cosmos.network/main/migrations/v7-to-v8#params-migration update deps fix app hash mismatch cleanup send_enable test
eda35d7
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)