Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: versiondb config item not exists in sdk 0.50 #1387

Merged
merged 4 commits into from
Apr 11, 2024

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Apr 11, 2024

Solution:

  • use dedicated versiondb config section to prepare for sdk 0.50 integration

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

  • New Features
    • Introduced dedicated configuration options for enabling and managing the VersionDB feature throughout the application.
  • Refactor
    • Removed unnecessary library imports and refactored conditional checks in the app initialization.
  • Documentation
    • Updated the changelog to prepare for future SDK integration.
  • Tests
    • Modified integration tests to support the new VersionDB configuration and functionality.

@yihuang yihuang requested a review from a team as a code owner April 11, 2024 03:12
@yihuang yihuang requested review from mmsqe and devashishdxt and removed request for a team April 11, 2024 03:12
Copy link
Contributor

coderabbitai bot commented Apr 11, 2024

Walkthrough

The recent updates focus on integrating and configuring the VersionDB feature across the application. Changes include setting up VersionDB configuration, removing outdated dependencies, and adjusting tests and app initialization to accommodate this new feature. These updates aim to prepare the system for the upcoming SDK 0.50 integration, improving data management efficiency and feature toggling flexibility.

Changes

File Path Change Summary
CHANGELOG.md Added a dedicated config section for versiondb in preparation for SDK 0.50 integration.
app/app.go Removed golang.org/x/exp/slices import and revamped versiondb enabling check.
cmd/cronosd/cmd/config.go Introduced VersionDBConfig struct and associated configuration functionalities.
cmd/cronosd/cmd/root.go Updated CustomAppConfig to incorporate VersionDB field and its initialization.
integration_tests/configs/default.jsonnet
integration_tests/test_basic.py
Adjusted to activate the versiondb feature, influencing data storage and test settings.

🐰✨
In the code meadow, a new feature takes flight,
VersionDB blooms, shedding old code's plight.
A rabbit's glee in data's streamlined dance,
With each commit, progress does enhance.
🌱🚀


Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 62171c7 and da57c4c.
Files selected for processing (1)
  • versiondb/README.md (1 hunks)
Additional comments not posted (1)
versiondb/README.md (1)

15-19: The configuration instructions for enabling VersionDB are clear and concise.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

CHANGELOG.md Outdated Show resolved Hide resolved
app/app.go Show resolved Hide resolved
Solution:
- use dedicated versiondb config section to prepare to sdk 0.50
  integration

Update CHANGELOG.md

Signed-off-by: yihuang <[email protected]>

cleanup
@yihuang yihuang changed the title Problem: store.streamers not exists in sdk 0.50 Problem: versiondb config item not exists in sdk 0.50 Apr 11, 2024
@yihuang yihuang enabled auto-merge April 11, 2024 04:06
Copy link
Collaborator

@mmsqe mmsqe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might update versiondb readme as well

@yihuang
Copy link
Collaborator Author

yihuang commented Apr 11, 2024

might update versiondb readme as well

good point, done.

@yihuang yihuang requested a review from mmsqe April 11, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants