Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: gravity-bridge is not audited #171

Merged
merged 4 commits into from
Oct 13, 2021

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Oct 13, 2021

Solution:

  • remove it for mainnet launch, could be added back later in an optional way
  • SendToEthereum native call always return an error.

ref: #168

Since the new binary is required by devops team for testnet, we could strip it for now, add discuss how to add it back in a conditional way later.

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Solution:
- strip it for now, could be added back later in an optional way
@yihuang yihuang requested a review from a team as a code owner October 13, 2021 06:53
@yihuang yihuang requested review from JayT106 and calvinaco and removed request for a team October 13, 2021 06:53
@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #171 (ac8dd24) into main (3ea70c5) will increase coverage by 5.11%.
The diff coverage is 54.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
+ Coverage   21.51%   26.63%   +5.11%     
==========================================
  Files          27       33       +6     
  Lines        1729     2328     +599     
==========================================
+ Hits          372      620     +248     
- Misses       1324     1662     +338     
- Partials       33       46      +13     
Impacted Files Coverage Δ
app/prefix.go 0.00% <0.00%> (ø)
app/test_helpers.go 0.00% <0.00%> (ø)
x/cronos/keeper/grpc_query.go 0.00% <0.00%> (ø)
x/cronos/keeper/msg_server.go 5.00% <0.00%> (-1.46%) ⬇️
x/cronos/module.go 59.64% <0.00%> (-2.17%) ⬇️
x/cronos/types/codec.go 0.00% <0.00%> (ø)
x/cronos/types/events.go 0.00% <ø> (ø)
x/cronos/types/params.go 57.35% <ø> (+3.78%) ⬆️
x/cronos/types/proposal.go 11.11% <ø> (ø)
x/cronos/types/query.pb.gw.go 0.00% <ø> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddc051c...ac8dd24. Read the comment docs.

x/cronos/keeper/evm_hooks_test.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@thomas-nguy thomas-nguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm,

The title of the PR is a bit weird though, maybe it should be just "Feature: remove gravity bridge" or "Problem: gravity-bridge is not audited"

@yihuang yihuang changed the title Problem: gravity-bridge is not removed Problem: gravity-bridge is not audited Oct 13, 2021
@yihuang
Copy link
Collaborator Author

yihuang commented Oct 13, 2021

Lgtm,

The title of the PR is a bit weird though, maybe it should be just "Feature: remove gravity bridge" or "Problem: gravity-bridge is not audited"

thanks, "gravity-bridge is not audited" is better.

@yihuang yihuang merged commit 7d1b62e into crypto-org-chain:main Oct 13, 2021
@yihuang yihuang deleted the strip-gravity branch October 13, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants