-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: gravity-bridge is not audited #171
Conversation
Solution: - strip it for now, could be added back later in an optional way
Codecov Report
@@ Coverage Diff @@
## main #171 +/- ##
==========================================
+ Coverage 21.51% 26.63% +5.11%
==========================================
Files 27 33 +6
Lines 1729 2328 +599
==========================================
+ Hits 372 620 +248
- Misses 1324 1662 +338
- Partials 33 46 +13
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm,
The title of the PR is a bit weird though, maybe it should be just "Feature: remove gravity bridge" or "Problem: gravity-bridge is not audited"
thanks, "gravity-bridge is not audited" is better. |
Solution:
ref: #168
Since the new binary is required by devops team for testnet, we could strip it for now, add discuss how to add it back in a conditional way later.
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)