-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: final cosmos-sdk 0.45.0 is not used #315
Conversation
Solution: - update dependencies
Codecov Report
@@ Coverage Diff @@
## main #315 +/- ##
===========================================
+ Coverage 21.51% 41.06% +19.54%
===========================================
Files 27 30 +3
Lines 1729 1505 -224
===========================================
+ Hits 372 618 +246
+ Misses 1324 841 -483
- Partials 33 46 +13
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
go.mod
Outdated
@@ -163,7 +163,7 @@ replace ( | |||
// See https://github.com/tecbot/gorocksdb/pull/216 | |||
github.com/tecbot/gorocksdb => github.com/cosmos/gorocksdb v1.1.1 | |||
|
|||
github.com/tharsis/ethermint => github.com/crypto-org-chain/ethermint v0.10.0-alpha1-cronos | |||
github.com/tharsis/ethermint => github.com/crypto-org-chain/ethermint v0.10.0-alpha2-cronos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it be v0.10.0-alpha1-cronos-2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should the Cosmos SDK version in ibc-go fork be updated as well?
maybe use a replace in cronos? |
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)