-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ibc hooks & add unit tests #35
Conversation
ce1fcf8
to
194d7a1
Compare
194d7a1
to
027285a
Compare
027285a
to
02647aa
Compare
02647aa
to
62d4b80
Compare
Codecov Report
@@ Coverage Diff @@
## main #35 +/- ##
==========================================
+ Coverage 3.26% 21.51% +18.24%
==========================================
Files 13 27 +14
Lines 1315 1729 +414
==========================================
+ Hits 43 372 +329
- Misses 1271 1324 +53
- Partials 1 33 +32
Continue to review full report at Codecov.
|
62d4b80
to
1e7a0d0
Compare
the CI failure could be fixed with running this command to update the gomod2nix.toml file:
|
c805888
to
3cdf8d9
Compare
37f3999
to
97d439e
Compare
97d439e
to
1ceec95
Compare
1ceec95
to
668e820
Compare
gomod2nix.toml is not up to date according to CI failure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than the CI failure, need to update the gomod2nix.toml.
#33 #36
Tested with Solo Machine and it works fine
Todo
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)