Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: transactions are not rejected when block gas limit exceeded #377

Merged
merged 2 commits into from
Mar 7, 2022
Merged

Problem: transactions are not rejected when block gas limit exceeded #377

merged 2 commits into from
Mar 7, 2022

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Mar 7, 2022 •
edited
Loading

Solution:

evmos/ethermint#964

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang yihuang requested a review from a team as a code owner March 7, 2022 01:43
@yihuang yihuang requested review from JayT106 and calvinaco and removed request for a team March 7, 2022 01:43
yihuang
yihuang commented Mar 7, 2022
View reviewed changes
go.mod
@@ -164,7 +164,7 @@ replace github.com/ethereum/go-ethereum => github.com/crypto-org-chain/go-ethere
// TODO: remove when ibc-go and ethermint upgrades cosmos-sdk
replace github.com/cosmos/cosmos-sdk => github.com/cosmos/cosmos-sdk v0.44.7-0.20220214161517-8a26cd10b4be

replace github.com/tharsis/ethermint => github.com/crypto-org-chain/ethermint v0.7.2-cronos-12
replace github.com/tharsis/ethermint => github.com/crypto-org-chain/ethermint v0.7.3-0.20220307013541-e3c38bb961a0
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/crypto-org-chain/ethermint/compare/v0.7.2-cronos-12...e3c38bb961a0?expand=1

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember you have said that doing it in checkTx won't help.

Can you describe a bit more about this solution?

Copy link
Collaborator Author

@yihuang yihuang Mar 7, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/cosmos/cosmos-sdk/blob/release/v0.44.x/baseapp/baseapp.go#L661

the issue is cosmos-sdk will fetch the gasWanted from the current gas meter after executing ante handler, but previously we have the infinite gas meter which returns zero here.
Fix it for checkTx mode should be enough to fix the tx inclusion issue.
But the fix deliverTx is also good to have because the gasWanted is also included in the tx result, but not critical I think.

yihuang
yihuang commented Mar 7, 2022
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@thomas-nguy
Copy link
Collaborator

can you change the PR title?

@yihuang yihuang changed the title Problem: checkTx/deliverTx don't report correct gasWanted Problem: transactions are not rejected when block gas limit exceeded Mar 7, 2022
yihuang
yihuang commented Mar 7, 2022
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@yihuang
Copy link
Collaborator Author

yihuang commented Mar 7, 2022 •
edited
Loading

can you change the PR title?

done, I removed the "add returnValue message on tracing" backport from this PR,better to do in a standalone PR.

@yihuang
Problem: checkTx/deliverTx don't report correct gasWanted
c3a93b6 
Solution:
- backport and modify the fix on ethermint to avoid breaking consensus.
- backport tx inclusion logic integration tests
- update nix dependencies to fix nix error
@yihuang yihuang merged commit 93f9bd9 into crypto-org-chain:release/v0.6.x Mar 7, 2022
@yihuang yihuang deleted the fix-gas-wanted branch March 7, 2022 10:18
@JayT106 JayT106 mentioned this pull request Mar 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-nguy thomas-nguy thomas-nguy approved these changes

@JayT106 JayT106 Awaiting requested review from JayT106 JayT106 is a code owner automatically assigned from crypto-org-chain/cronos-dev

@calvinaco calvinaco Awaiting requested review from calvinaco calvinaco is a code owner automatically assigned from crypto-org-chain/cronos-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yihuang @thomas-nguy