-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: no upgrade handler for v0.8.0-gravity-alpha2 #742
Problem: no upgrade handler for v0.8.0-gravity-alpha2 #742
Conversation
Codecov Report
@@ Coverage Diff @@
## main #742 +/- ##
==========================================
- Coverage 34.97% 34.57% -0.41%
==========================================
Files 28 28
Lines 1464 1481 +17
==========================================
Hits 512 512
- Misses 899 916 +17
Partials 53 53
|
Cronos Change log differences between alpha1 and alpha 2:
@yihuang do you think any extra operation needs to be handled for the upgrade? Seems like interchain-accounts was removed but not sure when it was introduced, but should no have consequences? |
yeah, it's retracted in |
I see, it seems it is already handled there https://github.com/crypto-org-chain/cronos/blob/main/app/upgrades.go#L44 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)