Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: no upgrade handler for v0.8.0-gravity-alpha2 #742

Merged

Conversation

thomas-nguy
Copy link
Collaborator

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@thomas-nguy thomas-nguy requested a review from a team as a code owner October 17, 2022 03:01
@thomas-nguy thomas-nguy requested review from JayT106 and calvinaco and removed request for a team October 17, 2022 03:01
@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #742 (be37c96) into main (f3e063a) will decrease coverage by 0.40%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #742      +/-   ##
==========================================
- Coverage   34.97%   34.57%   -0.41%     
==========================================
  Files          28       28              
  Lines        1464     1481      +17     
==========================================
  Hits          512      512              
- Misses        899      916      +17     
  Partials       53       53              
Impacted Files Coverage Δ
app/upgrades.go 0.00% <0.00%> (ø)

@thomas-nguy
Copy link
Collaborator Author

thomas-nguy commented Oct 18, 2022

Cronos Change log differences between alpha1 and alpha 2:

State Machine Breaking
https://github.com/crypto-org-chain/cronos/pull/647 Integrate ibc fee middleware.
https://github.com/crypto-org-chain/cronos/pull/672 Revert interchain-accounts integration.
https://github.com/crypto-org-chain/cronos/pull/695 Implement ADR-007, generic events format with indexed params.
https://github.com/crypto-org-chain/cronos/pull/728 Upgrade gravity bridge latest bugfix, including multi attestation processing and double spend check.

Bug Fixes
https://github.com/crypto-org-chain/cronos/pull/639 init and validate-genesis commands don't include experimental modules by default.

Improvement

https://github.com/crypto-org-chain/cronos/pull/549 Use custom tx indexer feature of ethermint.
https://github.com/crypto-org-chain/cronos/pull/673 Upgrade cosmos-sdk to 0.46.1 and ibc-go to v5.0.0-rc0.
https://github.com/crypto-org-chain/cronos/pull/702 Integrate the file state streamer.
https://github.com/crypto-org-chain/cronos/pull/714 Add option iavl-disable-fastnode to disable iavl fastnode indexing migration.
https://github.com/crypto-org-chain/cronos/pull/729 Update dependencies to recent versions.

@yihuang do you think any extra operation needs to be handled for the upgrade?

Seems like interchain-accounts was removed but not sure when it was introduced, but should no have consequences?

@yihuang
Copy link
Collaborator

yihuang commented Oct 18, 2022

Seems like interchain-accounts was removed but not sure when it was introduced, but should no have consequences?

yeah, it's retracted in v0.9.0-beta2, if it's included in alpha1, then need to delete the store in migration.

@thomas-nguy
Copy link
Collaborator Author

I see,

it seems it is already handled there

https://github.com/crypto-org-chain/cronos/blob/main/app/upgrades.go#L44

Copy link
Collaborator

@yihuang yihuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomas-nguy thomas-nguy enabled auto-merge (squash) October 18, 2022 06:24
@thomas-nguy thomas-nguy enabled auto-merge (squash) October 18, 2022 08:06
@thomas-nguy thomas-nguy merged commit 6ae1f7c into crypto-org-chain:main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants