Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: london hardfork number failed validation #771

Merged
merged 2 commits into from
Nov 17, 2022
Merged

Problem: london hardfork number failed validation #771

merged 2 commits into from
Nov 17, 2022

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Nov 17, 2022 •
edited
Loading

Solution:

  • set the london hardfork number to zero for testnet3 network

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@codecov
Copy link

codecov bot commented Nov 17, 2022 •
edited
Loading

Codecov Report

Merging #771 (60741ac) into release/v1.0.x (a6f5bbc) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release/v1.0.x     #771      +/-   ##
==================================================
- Coverage           34.71%   34.59%   -0.12%     
==================================================
  Files                  28       28              
  Lines                1475     1480       +5     
==================================================
  Hits                  512      512              
- Misses                910      915       +5     
  Partials               53       53
Impacted Files Coverage Δ
app/upgrades.go 0.00% <0.00%> (ø)

@yihuang yihuang marked this pull request as ready for review November 17, 2022 08:50
@yihuang yihuang requested a review from a team as a code owner November 17, 2022 08:50
@yihuang yihuang requested review from JayT106, thomas-nguy and devashishdxt and removed request for a team November 17, 2022 08:50
@yihuang yihuang enabled auto-merge (squash) November 17, 2022 08:56
@yihuang yihuang merged commit 4d14c8f into crypto-org-chain:release/v1.0.x Nov 17, 2022
JayT106
JayT106 reviewed Nov 17, 2022
View reviewed changes
app/upgrades.go
@@ -21,6 +22,11 @@ func (app *App) RegisterUpgradeHandlers(experimental bool) {
// Ref: https://github.com/crypto-org-chain/cronos/issues/755
params := app.EvmKeeper.GetParams(ctx)
params.ExtraEIPs = []int64{}

// fix the incorrect value on testnet parameters
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we reduce the scope only in testnet3?
or because the default London fork enabled is equal to zero in every Cronos chain?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, the default value is zero, so it should have no effect on other networks.

yihuang added a commit that referenced this pull request Jan 26, 2023
@yihuang @mmsqe @tomtau
Problem: v1.0.x changes are not merged into main (#816)
c6dd8f9 
* Problem: eth_sendTransaction is not tested

* Problem: json-rpc apis fail for legacy blocks after upgrade (#696)

* Problem: json-rpc apis fail for legacy blocks

Solution:
- keep the query handler in cosmos-sdk backward-compatible
- add integration test to check

* update sdk to upstream

* ibc-go to rc2

* Problem: file changes detection in workflow is problematic (backport #703) (#705)

* Problem: file changes detection in workflow is problematic

Solution:
- fix wildcards according the plugin's doc
- reformat python

* fix py-lint

* Problem: after v0.9.0 upgrade eth_call failed on old blocks (backport #713) (#719)

* Problem: after v0.9.0 upgrade eth_call failed on old blocks

Solution:
- make grpc query compatible with old format

* debug

* fix eth_call

* fix gravity upgrade test

* update ethermint to main branch

* update sdk

* Problem: state streamers are not integrated (backport #702) (#721)

Solution:
- integration the basic file streamer

* add integration test

* changelog

* fix build

* fix lint

* fix deliver tx event in cosmos-sdk

* fix integration test

* Update integration_tests/test_streamer.py

Signed-off-by: yihuang <[email protected]>

* update ethermint and fix build

* add a small cli utility into test_streamer.py

* fix integration test

* update sdk to upstream

Signed-off-by: yihuang <[email protected]>

Signed-off-by: yihuang <[email protected]>

* Problem: new iavl indexes migration is slow and not optional (#714) (#720)

* Problem: new iavl indexes migration is slow and not optional

Closes: #712
Solution:
- Integrate the option introduced in cosmos-sdk

* Update CHANGELOG.md

Signed-off-by: yihuang <[email protected]>

Signed-off-by: yihuang <[email protected]>

Signed-off-by: yihuang <[email protected]>

* Problem: recent dependencies are not used (backport #729) (#730)

* Problem: recent dependencies are not used (backport #729)

Solution:
- update cosmos-sdk to 0.46.2, ibc-go to v5.0.0, ethermint to recent main branch

Update highlights:
- new flag to disable fast node migration
- fix streaming listeners bug
- fix grpc server panic
- fix index-eth-tx error on empty db

* Update CHANGELOG.md

Signed-off-by: yihuang <[email protected]>

Signed-off-by: yihuang <[email protected]>

* Problem: chain state is inconsistent if upgrade migration is interrupted (#748)

* Problem: chain state is inconsistent if upgrade migration is interrupted

Solution:
- update cosmos-sdk with the fix

* Update CHANGELOG.md

Signed-off-by: yihuang <[email protected]>

* gomod2nix

* skip streamer test

Signed-off-by: yihuang <[email protected]>

* Problem: recent fixes in dependencies are not included (#752)

* Problem: recent fixes in dependencies are not included

Solution:
- update cosmos-sdk and iavl

* Update CHANGELOG.md

Signed-off-by: yihuang <[email protected]>

* fix build

Signed-off-by: yihuang <[email protected]>

* Problem: binary version is not bump to v1.0.0 (#753)

* Problem: recent fixes in dependencies are not used (#757)

* Problem: recent fixes in dependencies are not used

Solution:
- cosmos-sdk -> v0.46.4
- ethermint -> main
- ibc-go -> v5.0.1
- add dragonberry ics20 replacement

* maintain ethermint fork

* Problem: gas used is not backward compatible (#760)

Solution:
- revert the changes in ethermint

* Problem: evm execute result is non-deterministic with concurrent grpc query (#761)

* Problem: evm execute result is non-deterministic with concurrent grpc query

Solution:
- update dependencies to include the fix

* Update CHANGELOG.md

Signed-off-by: yihuang <[email protected]>

* Update go.mod

Signed-off-by: yihuang <[email protected]>

Signed-off-by: yihuang <[email protected]>

* Problem: extra_eips is not cleared on production network (#762)

* Problem: extra_eips is not cleared on production network

Closes: #755
Solution:
- add 1.0.0 upgrade plan to clear it

* Update CHANGELOG.md

Signed-off-by: yihuang <[email protected]>

* Update integration_tests/test_upgrade.py

Signed-off-by: yihuang <[email protected]>

* fix integration test

Signed-off-by: yihuang <[email protected]>

* Problem: no error log when iavl set failure trigger app hash mismatch (#763)

* Problem: no error log when iavl set failure trigger app hash mismatch

Solution:
- log the error in cosmos-sdk

* Update CHANGELOG.md

Signed-off-by: yihuang <[email protected]>

* PR merged

Signed-off-by: yihuang <[email protected]>

* Problem: different result from eth_getProof comparing with Ethereum (#764)

* Problem: different result from eth_getProof comparing with Ethereum

Solution:
- cherry-pick solution from ethermint, thanks @mmsqe

* Update CHANGELOG.md

Signed-off-by: yihuang <[email protected]>

Signed-off-by: yihuang <[email protected]>

* Problem: nix exceeds github rate limit occationally in CI (backport #766) (#768)

Solution:
- configure access-token
- update the action plugins

* Problem: fixes in ibc-go v5.1 are not included (#765)

* Problem: fixes in ibc-go v5.1 are not included

Solution:
- make a breaking change to upgrade to ibc-go `v5.1.0`.
- will do v1.0.0 upgrade on both testnet and mainnet.

* Update CHANGELOG.md

Signed-off-by: yihuang <[email protected]>

* fix lint

* include cache fix in tendermint

* update sdk

* Update CHANGELOG.md

Signed-off-by: yihuang <[email protected]>

* Update CHANGELOG.md

Signed-off-by: yihuang <[email protected]>

* make different plan name v1.0.0-testnet3 for testnet3

Signed-off-by: yihuang <[email protected]>
Co-authored-by: mmsqe <[email protected]>

* Problem: london hardfork number failed validation (#771)

* fix upgrade set parameters

* changelog

* Problem: formal v0.46.5 cosmos-sdk release is not used (#772)

* Problem: formal v0.46.5 cosmos-sdk release is not used

Solution:
- update dependency, should be non-breaking for cronos

* Update CHANGELOG.md

Signed-off-by: yihuang <[email protected]>

* update to v0.46.6

Signed-off-by: yihuang <[email protected]>

* Problem: final v1.0.0 is not released (#774)

Solution:
- update changelog

* Problem: manual prune cmd is not included (backport #781) (#782)

Solution:
- add to root cmd

* Problem: cosmos-sdk `v0.46.7` is not used (#790)

* Problem: cosmos-sdk `v0.46.7` is not used

Solution:
- update dependency
- `v0.46.7` fix a gov migration issue which affect query votes of old proposals.

* Update CHANGELOG.md

Signed-off-by: yihuang <[email protected]>

* use sdk streamers config

* fix streamer test

* fix file streamer integration test

* changelog

Signed-off-by: yihuang <[email protected]>

* Problem: discontinued ibc-go version (#802)

* Problem: discontinued ibc-go version

Solution:
- update ibc-go to v5.2.0.
- do another coordinated upgrade on testnet3.

* Update CHANGELOG.md

Signed-off-by: yihuang <[email protected]>

* Update app/upgrades.go

Signed-off-by: yihuang <[email protected]>

Signed-off-by: yihuang <[email protected]>

* Problem: production rocksdb configuration is not optimal (#813)

* Problem: production rocksdb configuration is not optimal

Solution:
- update related dependencies to allow customize rocksdb options.
- especially using rocksdb v7.
- tune rocksdb options.

* Update Makefile

Signed-off-by: yihuang <[email protected]>

* remove rocksdb from niv

* rocksdb options

* update flake

* fix build

* create_if_missing

* OptimizeLevelStyleCompaction and IncreaseParallelism

* remove SetLevelCompactionDynamicLevelBytes and add BlockCache

* fix integration test

* comments

Signed-off-by: yihuang <[email protected]>

* Problem: prometheus metrics is lost (#814)

* Problem: prometheus metrics is lost

Solution:
- setup correctly in ethermint

* changelog

* release v1.0.3

* Update CHANGELOG.md

Signed-off-by: yihuang <[email protected]>

* fix changelog

* fix merge

* Update integration_tests/test_upgrade.py

Co-authored-by: mmsqe <[email protected]>
Signed-off-by: yihuang <[email protected]>

* fix test

* Update integration_tests/configs/default.jsonnet

Signed-off-by: yihuang <[email protected]>

* fix test_multiple_attestation_processing

* fix changelog

Signed-off-by: yihuang <[email protected]>
Co-authored-by: mmsqe <[email protected]>
Co-authored-by: mmsqe <[email protected]>
Co-authored-by: Tomas Tauber <[email protected]>
@coderabbitai coderabbitai bot mentioned this pull request Apr 19, 2024
Merged
13 tasks
This was referenced Apr 26, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JayT106 JayT106 JayT106 left review comments

@thomas-nguy thomas-nguy thomas-nguy approved these changes

@devashishdxt devashishdxt devashishdxt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yihuang @JayT106 @devashishdxt @thomas-nguy