Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: node startup is slow #779

Merged
merged 9 commits into from
Feb 2, 2023

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Dec 1, 2022

Solution:

  • try iavl lazy mode

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Solution:
- update cosmos-sdk to support lazy loading
- support new config option `iavl-lazy-loading: true`.
@yihuang yihuang changed the base branch from release/v1.0.x to main February 1, 2023 16:11
@yihuang yihuang dismissed a stale review February 1, 2023 16:11

The base branch was changed.

CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: yihuang <[email protected]>
@yihuang yihuang added the backport/v1.0.x backport to release/v1.0.x label Feb 1, 2023
@yihuang yihuang marked this pull request as ready for review February 1, 2023 16:14
@yihuang yihuang requested a review from a team as a code owner February 1, 2023 16:14
@yihuang yihuang requested review from devashishdxt and leejw51crypto and removed request for a team February 1, 2023 16:14
go.mod Outdated Show resolved Hide resolved
@yihuang yihuang enabled auto-merge (squash) February 2, 2023 21:54
@yihuang yihuang merged commit d68f960 into crypto-org-chain:main Feb 2, 2023
@yihuang yihuang deleted the speedup-startup branch February 3, 2023 01:40
yihuang added a commit to yihuang/cronos that referenced this pull request Feb 3, 2023
* Problem: archive node startup is slow

Solution:
- update cosmos-sdk to support lazy loading
- support new config option `iavl-lazy-loading: true`.

* enable lazy loading in integration test

* Update CHANGELOG.md

Signed-off-by: yihuang <[email protected]>

* fix test config

* Update integration_tests/configs/cosmovisor.jsonnet

Co-authored-by: mmsqe <[email protected]>
Signed-off-by: yihuang <[email protected]>

* update to release branch

* bump to v0.46.9-rc.0

---------

Signed-off-by: yihuang <[email protected]>
Co-authored-by: mmsqe <[email protected]>
yihuang added a commit that referenced this pull request Feb 3, 2023
* Problem: archive node startup is slow

Solution:
- update cosmos-sdk to support lazy loading
- support new config option `iavl-lazy-loading: true`.

* enable lazy loading in integration test

* Update CHANGELOG.md



* fix test config

* Update integration_tests/configs/cosmovisor.jsonnet




* update to release branch

* bump to v0.46.9-rc.0

---------

Signed-off-by: yihuang <[email protected]>
Co-authored-by: mmsqe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v1.0.x backport to release/v1.0.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants