-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: unsafe experimental flag is not needed #834
Problem: unsafe experimental flag is not needed #834
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still keep package experimental and seems still have experimental in test_helpers
9023535
to
924dfe3
Compare
053fa53
to
071b154
Compare
Codecov Report
@@ Coverage Diff @@
## main #834 +/- ##
==========================================
+ Coverage 33.89% 34.32% +0.42%
==========================================
Files 30 30
Lines 1599 1579 -20
==========================================
Hits 542 542
+ Misses 1000 980 -20
Partials 57 57
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left a comment on the upgrade handler
071b154
to
a56243a
Compare
de79f43
to
cbb19e9
Compare
* skip gravity sim test * Update app/app.go Signed-off-by: mmsqe <[email protected]> * fix resolve --------- Signed-off-by: mmsqe <[email protected]>
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
Remove unsafe experimental flag
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)