Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: unsafe experimental flag is not needed #834

Conversation

thomas-nguy
Copy link
Collaborator

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

Remove unsafe experimental flag

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@thomas-nguy thomas-nguy requested a review from a team as a code owner February 2, 2023 02:43
@thomas-nguy thomas-nguy requested review from yihuang and mmsqe and removed request for a team February 2, 2023 02:43
Copy link
Collaborator

@mmsqe mmsqe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still keep package experimental and seems still have experimental in test_helpers

@thomas-nguy thomas-nguy force-pushed the thomas/remove-unsafe-experimental branch from 9023535 to 924dfe3 Compare February 2, 2023 03:02
@thomas-nguy thomas-nguy force-pushed the thomas/remove-unsafe-experimental branch 3 times, most recently from 053fa53 to 071b154 Compare February 2, 2023 05:12
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #834 (cbb19e9) into main (eeb5af9) will increase coverage by 0.42%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #834      +/-   ##
==========================================
+ Coverage   33.89%   34.32%   +0.42%     
==========================================
  Files          30       30              
  Lines        1599     1579      -20     
==========================================
  Hits          542      542              
+ Misses       1000      980      -20     
  Partials       57       57              
Impacted Files Coverage Δ
app/genesis.go 0.00% <0.00%> (ø)
app/state.go 0.00% <0.00%> (ø)
app/upgrades.go 0.00% <0.00%> (ø)
x/cronos/module.go 53.84% <ø> (+0.68%) ⬆️

Copy link
Contributor

@calvinaco calvinaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a comment on the upgrade handler

app/upgrades.go Outdated Show resolved Hide resolved
@thomas-nguy thomas-nguy force-pushed the thomas/remove-unsafe-experimental branch from 071b154 to a56243a Compare February 3, 2023 02:12
@thomas-nguy thomas-nguy force-pushed the thomas/remove-unsafe-experimental branch from de79f43 to cbb19e9 Compare February 4, 2023 08:17
@thomas-nguy thomas-nguy enabled auto-merge (squash) February 6, 2023 02:22
@thomas-nguy thomas-nguy merged commit 655f3b5 into crypto-org-chain:main Feb 6, 2023
mmsqe added a commit to mmsqe/cronos that referenced this pull request Mar 9, 2023
mmsqe added a commit that referenced this pull request Apr 20, 2023
* skip gravity sim test

* Update app/app.go

Signed-off-by: mmsqe <[email protected]>

* fix resolve

---------

Signed-off-by: mmsqe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants