-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: tx receipt don't contain events #93
Conversation
Solution: - convert tx hash when query logs - transaction index in logs start from 0
Codecov Report
@@ Coverage Diff @@
## main #93 +/- ##
==========================================
+ Coverage 21.51% 26.15% +4.64%
==========================================
Files 27 32 +5
Lines 1729 2183 +454
==========================================
+ Hits 372 571 +199
- Misses 1324 1575 +251
- Partials 33 37 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
(please fix the lint issue before merging)
386a244
to
532b18a
Compare
532b18a
to
e1b0994
Compare
464b7a7
to
98bca43
Compare
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)