fix(rpc): align query result of future block for eth_getTransactionCount (backport: #1638) #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unt (evmos#1638) * add future height check for get_transaction_count * add query future account test * fasten get_transaction_count test * add change doc * fix test * update nix * Update CHANGELOG.md Co-authored-by: MalteHerrmann <[email protected]> * Update rpc/backend/account_info.go Co-authored-by: MalteHerrmann <[email protected]> * update nix * add test for block height in future Co-authored-by: MalteHerrmann <[email protected]> Co-authored-by: MalteHerrmann <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return &n, err | ||
| } | ||
| height := blockNum.Int64() | ||
| currentHeight := int64(bn) |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
yihuang
reviewed
Mar 14, 2023
Codecov Report
@@ Coverage Diff @@
## release/v0.20.x-cronos #225 +/- ##
==========================================================
+ Coverage 57.33% 57.35% +0.02%
==========================================================
Files 108 108
Lines 10109 10121 +12
==========================================================
+ Hits 5796 5805 +9
- Misses 4067 4069 +2
- Partials 246 247 +1
|
yihuang
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for more info: evmos#1638
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)