feat: call Close method on app to cleanup resource on graceful shutdown #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
commented
May 17, 2023
yihuang
force-pushed
the
release/v0.20.x-cronos
branch
from
f74ccad
to
95759c2
Compare
Update CHANGELOG.md Signed-off-by: yihuang <[email protected]>
yihuang
force-pushed
the
release/v0.20.x-cronos
branch
from
95759c2
to
4ba39b2
Compare
Codecov Report
@@ Coverage Diff @@
## release/v0.20.x-cronos #246 +/- ##
==========================================================
+ Coverage 52.56% 56.68% +4.12%
==========================================================
Files 113 108 -5
Lines 11073 10243 -830
==========================================================
- Hits 5820 5806 -14
+ Misses 5006 4190 -816
Partials 247 247 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -350,6 +354,7 @@ | |||
| defer func() { | |||
| if tmNode.IsRunning() { | |||
| _ = tmNode.Stop() | |||
| _ = app.Close() | |||
Check warning
Code scanning / gosec
Returned error is not propagated up the stack.
mmsqe
approved these changes
May 26, 2023
Merged
11 tasks
mmsqe
added a commit
that referenced
this pull request
Jun 14, 2023
…wn (#246) (#275) Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> Co-authored-by: yihuang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)