Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: get unnecessary block result when only need header #526

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Sep 20, 2024

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@mmsqe mmsqe marked this pull request as ready for review September 20, 2024 01:53
@mmsqe mmsqe requested a review from yihuang September 20, 2024 01:54
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 60.06%. Comparing base (dbc7eb4) to head (795dc52).

Files with missing lines Patch % Lines
rpc/backend/blocks.go 76.47% 2 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #526      +/-   ##
===========================================
- Coverage    60.07%   60.06%   -0.02%     
===========================================
  Files          128      128              
  Lines         9827     9829       +2     
===========================================
  Hits          5904     5904              
- Misses        3342     3343       +1     
- Partials       581      582       +1     
Files with missing lines Coverage Δ
rpc/backend/utils.go 49.71% <100.00%> (ø)
rpc/backend/blocks.go 81.94% <76.47%> (-0.58%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants