Fix ecdhUnsafe for bindings #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! This seems to have fixed the issue. Thanks for the fast turnaround. |
|
Thanks for tests. Published as |
|
Hi @fanatid, the $ node
Welcome to Node.js v12.15.0.
Type ".help" for more information.
> const secp256k1 = require('secp256k1')
undefined
> secp256k1.ecd
secp256k1.ecdh secp256k1.ecdsaRecover secp256k1.ecdsaSign secp256k1.ecdsaVerify
> secp256k1.ecd
secp256k1.ecdh secp256k1.ecdsaRecover secp256k1.ecdsaSign secp256k1.ecdsaVerify
> secp256k1.ecdhUnsafe
undefined
> secp256k1.ecdh
[Function: ecdh]Was this an intentional change and can you explain what happened? We are stumbling upon this on the devp2p library trying to update the |
|
Hi @holgerd77! |
|
@fanatid thanks, great! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #138
@vpulim can you test this changes?