Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 13 add update tray icon #14

Merged
merged 2 commits into from
Dec 14, 2022
Merged

Issue 13 add update tray icon #14

merged 2 commits into from
Dec 14, 2022

Conversation

VsevolodGolovanov
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Dec 13, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@VsevolodGolovanov VsevolodGolovanov changed the base branch from develop to release/1.2.0 December 13, 2022 15:42
@VsevolodGolovanov VsevolodGolovanov mentioned this pull request Dec 13, 2022
Closed
overheadhunter
overheadhunter requested changes Dec 13, 2022
View reviewed changes
Copy link
Member

@overheadhunter overheadhunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also specify that this method throws an IllegalStateException, when it is called before an icon has been added.

src/main/java/org/cryptomator/integrations/tray/TrayMenuController.java Outdated Show resolved Hide resolved
@VsevolodGolovanov
Copy link
Contributor Author

@overheadhunter, done.

@infeo infeo added the enhancement New feature or request label Dec 14, 2022
@infeo infeo linked an issue Dec 14, 2022 that may be closed by this pull request
Tray-API: Add method to update tray icon #13
Closed
@infeo infeo merged commit 4addcad into cryptomator:release/1.2.0 Dec 14, 2022
@infeo
Copy link
Member

infeo commented Dec 14, 2022

Thanks @VsevolodGolovanov. We will release a new version of the integrations-api lib very soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infeo infeo infeo left review comments

@overheadhunter overheadhunter overheadhunter approved these changes

Assignees

@VsevolodGolovanov VsevolodGolovanov

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tray-API: Add method to update tray icon
4 participants
@VsevolodGolovanov @CLAassistant @infeo @overheadhunter