Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrated to new JEP 434 API (JDK20) #29

Merged
merged 11 commits into from
Apr 4, 2023
Merged

migrated to new JEP 434 API (JDK20) #29

merged 11 commits into from
Apr 4, 2023

Conversation

overheadhunter
Copy link
Member

@overheadhunter overheadhunter commented Mar 10, 2023

⚠️ please don't merge yet, this is merely a preparation to be able to switch to JDK 20 resolved

With JEP 434 the API changed significantly, which required plenty of changes, mostly due to the unification of MemoryAddress and MemorySegment.

@overheadhunter overheadhunter marked this pull request as ready for review March 10, 2023 11:22
@overheadhunter
Copy link
Member Author

I did not jextract on Windows btw. Applied a few changs manually (and it works!), but this should still be "corrected". 😉

Copy link
Member

@infeo infeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a smoke test on Ubuntu 22.04 with the HelloWorldFileSystem and the Posix mirror. Futhermore i was responsible for the windows package.

Looks good to me!

@infeo infeo merged commit 2691a86 into develop Apr 4, 2023
@infeo infeo deleted the feature/jdk20 branch April 4, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants