-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement simple rate limited free transaction feature #603
Comments
OK, some initial review:
|
@theoreticalbts thanks for the info. Would you please review #583 (BSIP10 percentage based transfer fee) first? This implementation is currently based on #583, and #583 can be merged to develop branch directly, no need to cherry-pick. I think we already discussed the principle you mentioned in another ticket, which is related to #583. I wrote some arguments in #583, can you comment in that ticket? To make it simpler, I put null-CER feature into #583's scope (and another new operation), which is mentioned in OP of #583. It doesn't matter if you like to create another ticket. |
We need a BSIP document for this feature. |
@theoreticalbts @bytemaster I guess it's better to postpone this feature after #554 implemented? Since this feature requires several extensions to the global system parameters. Or it's super high priority so it's better deploy it as is but asap? If yes, I'll do my best asap to re-branch it to be independent to #583 (percentage based transfer fee feature). Also need to consider using the new |
Looks like this can be easily cherry-pick to develop branch. It's quite independent from #583 now. I'll create a new branch for it. |
OK, the office command name is "rebase". Completed, and squashed to one commit: abitmore/bitshares-core@f9ad1df. Please review. @theoreticalbts @bytemaster |
This is AWESOME! Thank you sooo much .. |
Unit testing code added. Push request submitted. |
This issue was moved to bitshares/bitshares-core#186 |
update release
This ticket is for the implementation of a simplified version of "rate limited free transaction" feature which is introduced in bytemaster's blog post "How to build a Decentralized Application without Fees".
The simplified feature is:
Features:
for example, for normal users 1K BTS * 1day = 1BTS of fee, for AM 1KBTS * 1day = 2 BTS of fee, for LTM 1KBTS*1day=5BTS of fee
for example, users can use coin-days to pay at most 10 BTS of transfer fee, or 1 BTS of market order creating fee, or etc
for example, LTMs will have a cap of 100BTS, AM 50BTS, normal user 30BTS.
With the parameters defined in above examples, if an LTM has 1M BTS, she can accumulate 5000 BTS of fees per day, or about 3.5BTS per minute. In case when transfer fee is 30BTS and the committee set the cap of transfer to 30BTS , she can transfer once for free every 10 minutes.
Possible future extensions:
The text was updated successfully, but these errors were encountered: