-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow weird assignments #14815
Open
FnControlOption
wants to merge
8
commits into
crystal-lang:master
Choose a base branch
from
FnControlOption:call
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Disallow weird assignments #14815
+70
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blacksmoke16
added
kind:bug
A bug in the code. Does not apply to documentation, specs, etc.
topic:compiler:parser
labels
Jul 16, 2024
nobodywasishere
approved these changes
Jul 20, 2024
Found some more edge cases: foo = [1, 2, 3]
#foo.[]? = 1 # Error: undefined method '[]?='
#foo.[]? += 1 # Error: wrong number of arguments
#foo.[0]? = 1 # Error: unexpected token: "="
#foo.[0]? += 1 # Error: unexpected token: "+="
#foo[0]? = 1 # Error: unexpected token: "="
#foo[0]? += 1 # Error: unexpected token: "+="
#foo.tap &.[0]? = 1 # Error: undefined method '[]?='
#foo.tap &.[] 0 = 1 # Error: no overload matches
#foo.tap &.[] = 1 # Error: no overload matches
class Foo
def []=(value : Int)
puts value
end
end
foo = Foo.new
#foo.tap &.[]? = 1 # Error: undefined method '[]?='
#foo.tap &.[0]? = 1 # Error: undefined method '[]?='
foo.tap(&.[]=(1)) # 1
foo.tap &.[] = 1 # 1
foo.tap &.[]=(1) # 1
foo.tap &.[] 0 = 1 # 1
foo.tap &.[](0) = 1 # 1
class Foo
def foo
Foo.new
end
def []=(index : Int, value : Int)
puts [index, value]
end
end
foo.tap &.foo[0] = 1 # [0, 1]
foo.tap &.foo.[] 0 = 1 # [0, 1]
#foo.tap &.foo[0]? = 1 # Error: unexpected token: "=" Maybe instead of |
straight-shoota
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12830
Added
Call#dot_location
so that the AST fora[0]
can be differentiated froma.[] 0
. This makes it easier to disallowa.[] 0 = 1
Added a check for whether
Call#named_args
isnil
so thata b: 0 = 1
is disallowed and not treated like an assignment toa
(whereb: 0
was ignored)