Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #15 #16

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix #15 #16

wants to merge 1 commit into from

Conversation

aviggiano
Copy link

Fixes #15

@technovision99
Copy link
Contributor

I left some feedback on the original issue, but I also just noticed that I think you need to change the MIN_AMOUNT to 10000 and instead perform the calculation (x - xOut) * 10000 <= 591 * x,since 591/10000 ~= 5.91/100 - 5.91% (but as I said before I don't think this is an issue with the univ2 fee)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Potential issue with testPathIndependenceForSwaps test from part 3/4
2 participants
@aviggiano @technovision99