-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Index CoverageMap and SignatureMap by codehash (for performance) #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcz
reviewed
Jan 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. The immutable.sol seems to fail because contractAList
in genTx
is empty, so it looks like a bug with SignatureMap.
samalws-tob
force-pushed
the
cov-wip-10-rebased-again
branch
from
January 11, 2024 18:49
c8c1be1
to
87c635b
Compare
arcz
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so the CoverageMap and SignatureMap are indexed by contracts' codehashes, rather than their bytecode metadata. As a result:
Additional changes:
.codehash
property (which can be different if Solidity's immutables feature, which changes bytecode during compile time, is used). The real codehash is found using hevm'sfindSrc
function, and the results are cached in the codehash mapcodeContract
rather thancontract
to determine the current contract while keeping track of coverage (after talking this over with @arcz ). Beforehand, this was done in some places but not in others. I believe this should fix some delegate call behavior.